wiki.techinc.nl/tests/phpunit/integration/includes/Rest/Handler/LanguageLinksHandlerTest.php
DannyS712 41287e87d8 Add MediaWikiTitleCodec and NamespaceInfo to DummyServicesTrait
Move MockTitleTrait::makeMockTitleCodec to DummyServicesTrait, and
replace the two existing uses, which are in core. Add some new
uses instead of mocking each time.

Unfortunately, we cannot use an actual MediaWikiTitleCodec
for the tests in BadFileLookup, because those tests are unit tests
and a MalformedTitleException cannot be created in the context
of a unit test. BadFileLookupTest gets around this by using
a mock that throws a mock exception - add a comment inline
explaining why we cannot use a real MediaWikiTitleCodec.

Paired with adding of NamespaceInfo to make mocking the language
methods related to namespaces easier by matching the real
logic in the Language class to the extend possible. Update a few
tests to use the DummyServicesTrait for their NamespaceInfo services.

Change-Id: Ibd691ccf0e632e1bf0bc1f7e9ddc0c660d5cad32
2021-05-04 19:10:23 +00:00

164 lines
4.6 KiB
PHP

<?php
namespace MediaWiki\Tests\Rest\Handler;
use MediaWiki\Config\ServiceOptions;
use MediaWiki\Interwiki\ClassicInterwikiLookup;
use MediaWiki\Languages\LanguageNameUtils;
use MediaWiki\MediaWikiServices;
use MediaWiki\Page\PageIdentity;
use MediaWiki\Rest\Handler\LanguageLinksHandler;
use MediaWiki\Rest\LocalizedHttpException;
use MediaWiki\Rest\RequestData;
use MediaWiki\Tests\Unit\DummyServicesTrait;
use Title;
use Wikimedia\Message\MessageValue;
/**
* @covers \MediaWiki\Rest\Handler\LanguageLinksHandler
*
* @group Database
*/
class LanguageLinksHandlerTest extends \MediaWikiIntegrationTestCase {
use DummyServicesTrait;
use HandlerTestTrait;
public function addDBData() {
$defaults = [
'iw_local' => 0,
'iw_api' => '/w/api.php',
'iw_url' => ''
];
$base = 'https://wiki.test/';
$this->setMwGlobals( [
'wgInterwikiCache' => ClassicInterwikiLookup::buildCdbHash( [
[ 'iw_prefix' => 'de', 'iw_url' => $base . '/de', 'iw_wikiid' => 'dewiki' ] + $defaults,
[ 'iw_prefix' => 'en', 'iw_url' => $base . '/en', 'iw_wikiid' => 'enwiki' ] + $defaults,
[ 'iw_prefix' => 'fr', 'iw_url' => $base . '/fr', 'iw_wikiid' => 'frwiki' ] + $defaults,
] ),
] );
$this->editPage( __CLASS__ . '_Foo', 'Foo [[fr:Fou baux]] [[de:Füh bär]]' );
}
private function newHandler() {
$services = MediaWikiServices::getInstance();
$languageNameUtils = new LanguageNameUtils(
new ServiceOptions(
LanguageNameUtils::CONSTRUCTOR_OPTIONS,
[ 'ExtraLanguageNames' => [], 'UsePigLatinVariant' => false ]
),
$services->getHookContainer()
);
// DummyServicesTrait::getDummyMediaWikiTitleCodec
$titleCodec = $this->getDummyMediaWikiTitleCodec();
return new LanguageLinksHandler(
$services->getDBLoadBalancer(),
$languageNameUtils,
$titleCodec,
$titleCodec
);
}
private function assertLink( $expected, $actual ) {
foreach ( $expected as $key => $value ) {
$this->assertArrayHasKey( $key, $actual );
$this->assertSame( $value, $actual[$key], $key );
}
}
public function testExecute() {
$title = __CLASS__ . '_Foo';
$request = new RequestData( [ 'pathParams' => [ 'title' => $title ] ] );
$handler = $this->newHandler();
$data = $this->executeHandlerAndGetBodyData( $handler, $request );
$this->assertCount( 2, $data );
$links = [];
foreach ( $data as $row ) {
$links[$row['code']] = $row;
}
$this->assertArrayHasKey( 'de', $links );
$this->assertArrayHasKey( 'fr', $links );
$this->assertLink( [
'code' => 'de',
'name' => 'Deutsch',
'title' => 'Füh bär',
'key' => 'Füh_bär',
], $links['de'] );
$this->assertLink( [
'code' => 'fr',
'name' => 'français',
'title' => 'Fou baux',
'key' => 'Fou_baux',
], $links['fr'] );
}
public function testCacheControl() {
$title = Title::newFromText( __METHOD__ );
$this->editPage( $title->getPrefixedDBkey(), 'First' );
$request = new RequestData( [ 'pathParams' => [ 'title' => $title->getPrefixedDBkey() ] ] );
$handler = $this->newHandler();
$response = $this->executeHandler( $handler, $request );
$firstETag = $response->getHeaderLine( 'ETag' );
$this->assertSame(
wfTimestamp( TS_RFC2822, $title->getTouched() ),
$response->getHeaderLine( 'Last-Modified' )
);
$this->editPage( $title->getPrefixedDBkey(), 'Second' );
Title::clearCaches();
$handler = $this->newHandler();
$response = $this->executeHandler( $handler, $request );
$this->assertNotEquals( $response->getHeaderLine( 'ETag' ), $firstETag );
$this->assertSame(
wfTimestamp( TS_RFC2822, $title->getTouched() ),
$response->getHeaderLine( 'Last-Modified' )
);
}
public function testExecute_notFound() {
$title = __CLASS__ . '_Xyzzy';
$request = new RequestData( [ 'pathParams' => [ 'title' => $title ] ] );
$handler = $this->newHandler();
$this->expectExceptionObject(
new LocalizedHttpException( new MessageValue( 'rest-nonexistent-title' ), 404 )
);
$this->executeHandler( $handler, $request );
}
public function testExecute_forbidden() {
// The mock PermissionHandler forbids access to pages that have "Forbidden" in the name
$title = __CLASS__ . '_Forbidden';
$this->editPage( $title, 'Forbidden text' );
$request = new RequestData( [ 'pathParams' => [ 'title' => $title ] ] );
$handler = $this->newHandler();
$this->expectExceptionObject(
new LocalizedHttpException( new MessageValue( 'rest-permission-denied-title' ), 403 )
);
$this->executeHandler( $handler, $request, [ 'userCan' => false ], [], [], [],
$this->mockAnonAuthority( static function ( string $permission, ?PageIdentity $target ) {
return $target && !preg_match( '/Forbidden/', $target->getDBkey() );
} ) );
}
}