wiki.techinc.nl/tests/phpunit/includes/media/PNGHandlerTest.php
Tim Starling 5e30a927bc tests: Make some PHPUnit data providers static
Just methods where adding "static" to the declaration was enough, I
didn't do anything with providers that used $this.

Initially by search and replace. There were many mistakes which I
found mostly by running the PHPStorm inspection which searches for
$this usage in a static method. Later I used the PHPStorm "make static"
action which avoids the more obvious mistakes.

Bug: T332865
Change-Id: I47ed6692945607dfa5c139d42edbd934fa4f3a36
2023-03-24 02:53:57 +00:00

198 lines
5 KiB
PHP

<?php
/**
* @group Media
*/
class PNGHandlerTest extends MediaWikiMediaTestCase {
/** @var PNGHandler */
protected $handler;
protected function setUp(): void {
parent::setUp();
$this->handler = new PNGHandler();
}
/**
* @return array Expected metadata for a broken file. This tests backwards
* compatibility with existing DB rows, so can't be changed.
*/
private function brokenFile() {
return [ '_error' => '0' ];
}
/**
* @covers PNGHandler::getSizeAndMetadata
*/
public function testInvalidFile() {
$res = $this->handler->getSizeAndMetadata( null, $this->filePath . '/README' );
$this->assertEquals(
[
'metadata' => $this->brokenFile()
],
$res );
}
/**
* @param string $filename Basename of the file to check
* @param bool $expected Expected result.
* @dataProvider provideIsAnimated
* @covers PNGHandler::isAnimatedImage
*/
public function testIsAnimanted( $filename, $expected ) {
$file = $this->dataFile( $filename, 'image/png' );
$actual = $this->handler->isAnimatedImage( $file );
$this->assertEquals( $expected, $actual );
}
public static function provideIsAnimated() {
return [
[ 'Animated_PNG_example_bouncing_beach_ball.png', true ],
[ '1bit-png.png', false ],
];
}
/**
* @param string $filename
* @param int $expected Total image area
* @dataProvider provideGetImageArea
* @covers PNGHandler::getImageArea
*/
public function testGetImageArea( $filename, $expected ) {
$file = $this->dataFile( $filename, 'image/png' );
$actual = $this->handler->getImageArea( $file );
$this->assertEquals( $expected, $actual );
}
public static function provideGetImageArea() {
return [
[ '1bit-png.png', 2500 ],
[ 'greyscale-png.png', 2500 ],
[ 'Png-native-test.png', 126000 ],
[ 'Animated_PNG_example_bouncing_beach_ball.png', 10000 ],
];
}
/**
* @param string $metadata Serialized metadata
* @param int $expected One of the class constants of PNGHandler
* @dataProvider provideIsMetadataValid
* @covers PNGHandler::isFileMetadataValid
*/
public function testIsFileMetadataValid( $metadata, $expected ) {
$actual = $this->handler->isFileMetadataValid( $this->getMockFileWithMetadata( $metadata ) );
$this->assertEquals( $expected, $actual );
}
public static function provideIsMetadataValid() {
return [
[ '0', PNGHandler::METADATA_GOOD ],
[ '', PNGHandler::METADATA_BAD ],
[ 'a:0:{}', PNGHandler::METADATA_BAD ],
[ 'Something invalid!', PNGHandler::METADATA_BAD ],
[
'a:6:{s:10:"frameCount";i:0;s:9:"loopCount";i:1;s:8:"duration";d:0;s:8:"bitDepth";i:8;s:9:"colorType";s:10:"truecolour";s:8:"metadata";a:1:{s:15:"_MW_PNG_VERSION";i:1;}}',
PNGHandler::METADATA_GOOD
],
];
// phpcs:enable
}
/**
* @param string $filename
* @param string $expected Serialized array
* @dataProvider provideGetSizeAndMetadata
* @covers PNGHandler::getSizeAndMetadata
*/
public function testGetSizeAndMetadata( $filename, $expected ) {
$file = $this->dataFile( $filename, 'image/png' );
$actual = $this->handler->getSizeAndMetadata( $file, "$this->filePath/$filename" );
$this->assertEquals( $expected, $actual );
}
public static function provideGetSizeAndMetadata() {
return [
[
'rgb-na-png.png',
[
'width' => 50,
'height' => 50,
'bits' => 8,
'metadata' => [
'frameCount' => 0,
'loopCount' => 1,
'duration' => 0.0,
'bitDepth' => 8,
'colorType' => 'truecolour',
'metadata' => [
'_MW_PNG_VERSION' => 1,
],
],
],
],
[
'xmp.png',
[
'width' => 50,
'height' => 50,
'bits' => 1,
'metadata' => [
'frameCount' => 0,
'loopCount' => 1,
'duration' => 0.0,
'bitDepth' => 1,
'colorType' => 'index-coloured',
'metadata' => [
'SerialNumber' => '123456789',
'_MW_PNG_VERSION' => 1,
],
]
]
],
];
}
/**
* @param string $filename
* @param array $expected Expected standard metadata
* @dataProvider provideGetIndependentMetaArray
* @covers PNGHandler::getCommonMetaArray
*/
public function testGetIndependentMetaArray( $filename, $expected ) {
$file = $this->dataFile( $filename, 'image/png' );
$actual = $this->handler->getCommonMetaArray( $file );
$this->assertEquals( $expected, $actual );
}
public static function provideGetIndependentMetaArray() {
return [
[ 'rgb-na-png.png', [] ],
[ 'xmp.png',
[
'SerialNumber' => '123456789',
]
],
];
}
/**
* @param string $filename
* @param float $expectedLength
* @dataProvider provideGetLength
* @covers PNGHandler::getLength
*/
public function testGetLength( $filename, $expectedLength ) {
$file = $this->dataFile( $filename, 'image/png' );
$actualLength = $file->getLength();
$this->assertEqualsWithDelta( $expectedLength, $actualLength, 0.00001 );
}
public static function provideGetLength() {
return [
[ 'Animated_PNG_example_bouncing_beach_ball.png', 1.5 ],
[ 'Png-native-test.png', 0.0 ],
[ 'greyscale-png.png', 0.0 ],
[ '1bit-png.png', 0.0 ],
];
}
}