fc324a18d2
When dumping an array, PHPUnit limit the number of characters shown. That would just hide the relevant part of the path: 1) StructureTest::testUnitTestFileNamesEndWithTest [...] Array ( + 0 => '/some/path/tests/phpunit/incl...ge.php' + 1 => '/some/path/tests/phpunit/incl...ki.php' ) By stripping the common path ( /some/path/tests/phpunit ), we end up with a more useful output: Array ( + 0 => 'includes/RecentChange.php' + 1 => 'includes/Wiki.php' )
59 lines
1.5 KiB
PHP
59 lines
1.5 KiB
PHP
<?php
|
|
/**
|
|
* The tests here verify the structure of the code. This is for outright bugs,
|
|
* not just style issues.
|
|
*/
|
|
|
|
class StructureTest extends MediaWikiTestCase {
|
|
/**
|
|
* Verify all files that appear to be tests have file names ending in
|
|
* Test. If the file names do not end in Test, they will not be run.
|
|
*/
|
|
public function testUnitTestFileNamesEndWithTest() {
|
|
if ( wfIsWindows() ) {
|
|
$this->markTestSkipped( 'This test does not work on Windows' );
|
|
}
|
|
$rootPath = escapeshellarg( __DIR__ );
|
|
$testClassRegex = implode( '|', array(
|
|
'ApiFormatTestBase',
|
|
'ApiTestCase',
|
|
'MediaWikiLangTestCase',
|
|
'MediaWikiTestCase',
|
|
'PHPUnit_Framework_TestCase',
|
|
) );
|
|
$testClassRegex = "^class .* extends ($testClassRegex)";
|
|
$finder = "find $rootPath -name '*.php' '!' -name '*Test.php'" .
|
|
" | xargs grep -El '$testClassRegex|function suite\('";
|
|
|
|
$results = null;
|
|
$exitCode = null;
|
|
exec($finder, $results, $exitCode);
|
|
|
|
$this->assertEquals(
|
|
0,
|
|
$exitCode,
|
|
'Verify find/grep command succeeds.'
|
|
);
|
|
|
|
$results = array_filter(
|
|
$results,
|
|
array( $this, 'filterSuites' )
|
|
);
|
|
$strip = strlen( $rootPath ) - 1;
|
|
foreach( $results as $k => $v) {
|
|
$results[$k] = substr( $v, $strip );
|
|
}
|
|
$this->assertEquals(
|
|
array(),
|
|
$results,
|
|
"Unit test file in $rootPath must end with Test."
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Filter to remove testUnitTestFileNamesEndWithTest false positives.
|
|
*/
|
|
public function filterSuites( $filename ) {
|
|
return strpos( $filename, __DIR__ . '/suites/' ) !== 0;
|
|
}
|
|
}
|