115410f077
A number of different argument variants were deprecated in 1.34, and direct calls to the Parser constructor were deprecated at the same time (a ParserFactory should be used instead). These were hard-deprecated in 1.35. They should be safe to remove now. Code search: https://codesearch.wmcloud.org/deployed/?q=new%20Parser%5C%28&i=nope&files=%5C.php%24&excludeFiles=&repos= Bug: T236811 Change-Id: I58f7b3ba1b1d62851b2db71197a8d9129e8d473d
83 lines
2.6 KiB
PHP
83 lines
2.6 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @covers Parser::__construct
|
|
*/
|
|
class ParserTest extends MediaWikiIntegrationTestCase {
|
|
/**
|
|
* Helper method to create mocks
|
|
* @return array
|
|
*/
|
|
private function createConstructorArguments() {
|
|
// Create a mock Config object that will satisfy ServiceOptions::__construct
|
|
$mockConfig = $this->createMock( Config::class );
|
|
$mockConfig->method( 'has' )->willReturn( true );
|
|
$mockConfig->method( 'get' )->will(
|
|
$this->returnCallback( function ( $arg ) {
|
|
return ( $arg === 'TidyConfig' ) ? null : 'I like otters.';
|
|
} )
|
|
);
|
|
|
|
// Stub out a MagicWordFactory so the Parser can initialize its
|
|
// function hooks when it is created.
|
|
$mwFactory = $this->getMockBuilder( MagicWordFactory::class )
|
|
->disableOriginalConstructor()
|
|
->setMethods( [ 'get', 'getVariableIDs' ] )
|
|
->getMock();
|
|
$mwFactory
|
|
->method( 'get' )->will( $this->returnCallback( function ( $arg ) {
|
|
$mw = $this->getMockBuilder( MagicWord::class )
|
|
->disableOriginalConstructor()
|
|
->setMethods( [ 'getSynonyms' ] )
|
|
->getMock();
|
|
$mw->method( 'getSynonyms' )->willReturn( [] );
|
|
return $mw;
|
|
} ) );
|
|
$mwFactory
|
|
->method( 'getVariableIDs' )->willReturn( [] );
|
|
|
|
return [
|
|
$this->createMock( MediaWiki\Config\ServiceOptions::class ),
|
|
$mwFactory,
|
|
$this->createMock( Language::class ),
|
|
$this->createMock( ParserFactory::class ),
|
|
'a snail can sleep for three years',
|
|
$this->createMock( MediaWiki\Special\SpecialPageFactory::class ),
|
|
$this->createMock( MediaWiki\Linker\LinkRendererFactory::class ),
|
|
$this->createMock( NamespaceInfo::class ),
|
|
new Psr\Log\NullLogger(),
|
|
$this->createMock( MediaWiki\BadFileLookup::class ),
|
|
$this->createMock( MediaWiki\Languages\LanguageConverterFactory::class ),
|
|
$this->createMock( MediaWiki\HookContainer\HookContainer::class ),
|
|
$this->createMock( MediaWiki\Tidy\TidyDriverBase::class ),
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @covers Parser::__construct
|
|
*/
|
|
public function testConstructorArguments() {
|
|
$args = $this->createConstructorArguments();
|
|
|
|
// Fool Parser into thinking we are constructing via a ParserFactory
|
|
ParserFactory::$inParserFactory += 1;
|
|
try {
|
|
$parser = new Parser( ...$args );
|
|
} finally {
|
|
ParserFactory::$inParserFactory -= 1;
|
|
}
|
|
|
|
$refObject = new ReflectionObject( $parser );
|
|
foreach ( $refObject->getProperties() as $prop ) {
|
|
$prop->setAccessible( true );
|
|
foreach ( $args as $idx => $mockTest ) {
|
|
if ( $prop->getValue( $parser ) === $mockTest ) {
|
|
unset( $args[$idx] );
|
|
}
|
|
}
|
|
}
|
|
|
|
$this->assertSame( [], $args, 'Not all arguments to the Parser constructor were ' .
|
|
'found on the Parser object' );
|
|
}
|
|
}
|