33a191b20d
Why: * Maintenance scripts in core have low test coverage * Improving this will reduce the chances of regressions and bugs * Some files are mostly covered, and expanding their associated tests should fully cover them or at least further improve coverage. What: * Expand MigrateUserGroupTest Bug: T371167 Change-Id: I3c40317988f822e077634cf63ab292df7ef66806
77 lines
2.8 KiB
PHP
77 lines
2.8 KiB
PHP
<?php
|
|
|
|
namespace MediaWiki\Tests\Maintenance;
|
|
|
|
use MediaWiki\User\UserIdentity;
|
|
use MigrateUserGroup;
|
|
|
|
/**
|
|
* @covers \MigrateUserGroup
|
|
* @group Database
|
|
* @author Dreamy Jazz
|
|
*/
|
|
class MigrateUserGroupTest extends MaintenanceBaseTestCase {
|
|
|
|
protected function getMaintenanceClass() {
|
|
return MigrateUserGroup::class;
|
|
}
|
|
|
|
/**
|
|
* Creates several testing users, and adds them to the specified $group.
|
|
*
|
|
* @param string $group The group the users should be in
|
|
* @param int $numberOfUsers The number of users to create
|
|
* @return UserIdentity[] The users that were created
|
|
*/
|
|
private function createTestUsersWithGroup( string $group, int $numberOfUsers ): array {
|
|
$userGroupManager = $this->getServiceContainer()->getUserGroupManager();
|
|
$returnArray = [];
|
|
for ( $i = 0; $i < $numberOfUsers; $i++ ) {
|
|
$user = $this->getMutableTestUser()->getUserIdentity();
|
|
$userGroupManager->addUserToGroup( $user, $group );
|
|
$returnArray[] = $user;
|
|
}
|
|
return $returnArray;
|
|
}
|
|
|
|
public function testExecute() {
|
|
// Test moving 3 users with the "bot" group to the "sysop" group
|
|
$testUsers = $this->createTestUsersWithGroup( 'bot', 3 );
|
|
$this->maintenance->setArg( 'oldgroup', 'bot' );
|
|
$this->maintenance->setArg( 'newgroup', 'sysop' );
|
|
$this->maintenance->execute();
|
|
// Verify that the move correctly occurred.
|
|
foreach ( $testUsers as $testUser ) {
|
|
$testUserGroups = $this->getServiceContainer()->getUserGroupManager()->getUserGroups( $testUser );
|
|
$this->assertContains( 'sysop', $testUserGroups );
|
|
$this->assertNotContains( 'bot', $testUserGroups );
|
|
}
|
|
$this->expectOutputRegex( "/Done! 3 users in group 'bot' are now in 'sysop' instead.\n/" );
|
|
}
|
|
|
|
public function testExecuteWithOneUserInNewGroup() {
|
|
// Test moving 5 users with the "bot" group to the "sysop" group, adding one already into the "sysop" group
|
|
// to test that functionality.
|
|
$testUsers = $this->createTestUsersWithGroup( 'bot', 5 );
|
|
$this->getServiceContainer()->getUserGroupManager()
|
|
->addUserToGroup( $testUsers[1], 'sysop' );
|
|
$this->maintenance->setArg( 'oldgroup', 'bot' );
|
|
$this->maintenance->setArg( 'newgroup', 'sysop' );
|
|
$this->maintenance->execute();
|
|
// Verify that the move correctly occurred.
|
|
foreach ( $testUsers as $testUser ) {
|
|
$testUserGroups = $this->getServiceContainer()->getUserGroupManager()->getUserGroups( $testUser );
|
|
$this->assertContains( 'sysop', $testUserGroups );
|
|
$this->assertNotContains( 'bot', $testUserGroups );
|
|
}
|
|
$this->expectOutputRegex( "/Done! 5 users in group 'bot' are now in 'sysop' instead.\n/" );
|
|
}
|
|
|
|
public function testExecuteForNoUsersInOldGroup() {
|
|
$this->maintenance->setArg( 'oldgroup', 'bot' );
|
|
$this->maintenance->setArg( 'newgroup', 'sysop' );
|
|
$this->expectOutputRegex( "/no users in the 'bot' group/" );
|
|
$this->expectCallToFatalError();
|
|
$this->maintenance->execute();
|
|
}
|
|
}
|