Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
wiki.techinc.nl/tests/phpunit/data/ParserCache
History
C. Scott Ananian ea4bedee9d Remove misleading test in SerializationTestTrain::validateObjectEquality() 
The initial object comparison using `==` compares all the property values
using `==` as well.  This causes (for example) the string "1" to compare
as equal to the number `1`, the empty string `""` to compare as equal
to the number `0` and other surprising things.

It appears that this comparison was done at an attempt at performance
optimization, but that has little place in a test suite.  Use the full
recursive strict comparison instead.

This requires updating one ParserCache test case which was apparently
created incorrectly (or not properly updated) and relied on the
previous behavior (numbers comparing as equal to strings) to pass.

Change-Id: Ife0e9ccc7be0f4933975bb326203693bc15a9658
2022-03-31 09:50:51 -04:00
..
1.31-CacheTime-cacheExpiry.serialized Add deserialization acceptance tests for ParserOutput 2020-10-12 08:55:32 +00:00
1.31-CacheTime-cacheRevisionId.serialized
1.31-CacheTime-cacheTime.serialized
1.31-CacheTime-empty.serialized Add deserialization acceptance tests for ParserOutput 2020-10-12 08:55:32 +00:00
1.31-CacheTime-usedOptions.serialized Add deserialization acceptance tests for ParserOutput 2020-10-12 08:55:32 +00:00
1.31-ParserOutput-empty.serialized Add deserialization acceptance tests for ParserOutput 2020-10-12 08:55:32 +00:00
1.31-ParserOutput-extensionData.serialized
1.31-ParserOutput-pageProperties.serialized Add deserialization acceptance tests for ParserOutput 2020-10-12 08:55:32 +00:00
1.31-ParserOutput-text.serialized
1.31-ParserOutput-usedOptions.serialized Add deserialization acceptance tests for ParserOutput 2020-10-12 08:55:32 +00:00
1.31-ParserOutput-withMetadata.serialized Update ParserCache serialization test cases to use valid category keys 2022-02-17 12:12:53 -05:00
1.34-CacheTime-cacheExpiry.serialized Add deserialization acceptance tests for ParserOutput 2020-10-12 08:55:32 +00:00
1.34-CacheTime-cacheRevisionId.serialized Add deserialization acceptance tests for ParserOutput 2020-10-12 08:55:32 +00:00
1.34-CacheTime-cacheTime.serialized
1.34-CacheTime-empty.serialized Add deserialization acceptance tests for ParserOutput 2020-10-12 08:55:32 +00:00
1.34-CacheTime-usedOptions.serialized Add deserialization acceptance tests for ParserOutput 2020-10-12 08:55:32 +00:00
1.34-ParserOutput-empty.serialized Add deserialization acceptance tests for ParserOutput 2020-10-12 08:55:32 +00:00
1.34-ParserOutput-extensionData.serialized
1.34-ParserOutput-pageProperties.serialized Add deserialization acceptance tests for ParserOutput 2020-10-12 08:55:32 +00:00
1.34-ParserOutput-text.serialized
1.34-ParserOutput-usedOptions.serialized Add deserialization acceptance tests for ParserOutput 2020-10-12 08:55:32 +00:00
1.34-ParserOutput-withMetadata.serialized Update ParserCache serialization test cases to use valid category keys 2022-02-17 12:12:53 -05:00
1.34-ParserOutput-withMetadataPost1_31.serialized Add deserialization acceptance tests for ParserOutput 2020-10-12 08:55:32 +00:00
1.35-CacheTime-cacheExpiry.serialized Add deserialization acceptance tests for ParserOutput 2020-10-12 08:55:32 +00:00
1.35-CacheTime-cacheRevisionId.serialized Add deserialization acceptance tests for ParserOutput 2020-10-12 08:55:32 +00:00
1.35-CacheTime-cacheTime.serialized
1.35-CacheTime-empty.serialized Add deserialization acceptance tests for ParserOutput 2020-10-12 08:55:32 +00:00
1.35-CacheTime-usedOptions.serialized Add deserialization acceptance tests for ParserOutput 2020-10-12 08:55:32 +00:00
1.35-ParserOutput-empty.serialized Add deserialization acceptance tests for ParserOutput 2020-10-12 08:55:32 +00:00
1.35-ParserOutput-extensionData.serialized Add deserialization acceptance tests for ParserOutput 2020-10-12 08:55:32 +00:00
1.35-ParserOutput-pageProperties.serialized Add deserialization acceptance tests for ParserOutput 2020-10-12 08:55:32 +00:00
1.35-ParserOutput-text.serialized
1.35-ParserOutput-usedOptions.serialized Add deserialization acceptance tests for ParserOutput 2020-10-12 08:55:32 +00:00
1.35-ParserOutput-withMetadata.serialized Update ParserCache serialization test cases to use valid category keys 2022-02-17 12:12:53 -05:00
1.35-ParserOutput-withMetadataPost1_31.serialized Add deserialization acceptance tests for ParserOutput 2020-10-12 08:55:32 +00:00
1.35-ParserOutput-withMetadataPost1_34.serialized Add deserialization acceptance tests for ParserOutput 2020-10-12 08:55:32 +00:00
1.36-CacheTime-cacheExpiry.json CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-CacheTime-cacheExpiry.serialized CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-CacheTime-cacheRevisionId.json CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-CacheTime-cacheRevisionId.serialized CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-CacheTime-cacheTime.json CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-CacheTime-cacheTime.serialized CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-CacheTime-empty.json CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-CacheTime-empty.serialized CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-CacheTime-usedOptions.json CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-CacheTime-usedOptions.serialized CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-ParserOutput-binaryPageProperties.json CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-ParserOutput-binaryPageProperties.serialized CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-ParserOutput-cacheTime.json Hard-deprecate all public property access on CacheTime and ParserOutput. 2021-10-13 13:27:16 -04:00
1.36-ParserOutput-cacheTime.serialized Hard-deprecate all public property access on CacheTime and ParserOutput. 2021-10-13 13:27:16 -04:00
1.36-ParserOutput-empty.json CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-ParserOutput-empty.serialized CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-ParserOutput-extensionData.json CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-ParserOutput-extensionData.serialized CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-ParserOutput-pageProperties.json CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-ParserOutput-pageProperties.serialized CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-ParserOutput-text.json CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-ParserOutput-text.serialized CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-ParserOutput-usedOptions.json CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-ParserOutput-usedOptions.serialized CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-ParserOutput-withMetadata.json Update ParserCache serialization test cases to use valid category keys 2022-02-17 12:12:53 -05:00
1.36-ParserOutput-withMetadata.serialized Remove misleading test in SerializationTestTrain::validateObjectEquality() 2022-03-31 09:50:51 -04:00
1.36-ParserOutput-withMetadataPost1_31.json CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-ParserOutput-withMetadataPost1_31.serialized CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-ParserOutput-withMetadataPost1_34.json CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36-ParserOutput-withMetadataPost1_34.serialized CacheTime: remove mVersion field 2021-01-04 10:29:52 -06:00
1.36_wmf.16-CacheTime-empty.json Merge CacheTime and ParserOutput accessedOptions properties 2020-11-19 10:12:39 -07:00
1.36_wmf.16-CacheTime-empty.serialized Merge CacheTime and ParserOutput accessedOptions properties 2020-11-19 10:12:39 -07:00
1.36_wmf.16-CacheTime-usedOptions.json Merge CacheTime and ParserOutput accessedOptions properties 2020-11-19 10:12:39 -07:00
1.36_wmf.16-CacheTime-usedOptions.serialized Merge CacheTime and ParserOutput accessedOptions properties 2020-11-19 10:12:39 -07:00
1.36_wmf.16-ParserOutput-empty.json Merge CacheTime and ParserOutput accessedOptions properties 2020-11-19 10:12:39 -07:00
1.36_wmf.16-ParserOutput-empty.serialized Merge CacheTime and ParserOutput accessedOptions properties 2020-11-19 10:12:39 -07:00
1.36_wmf.16-ParserOutput-usedOptions.json Merge CacheTime and ParserOutput accessedOptions properties 2020-11-19 10:12:39 -07:00
1.36_wmf.16-ParserOutput-usedOptions.serialized Merge CacheTime and ParserOutput accessedOptions properties 2020-11-19 10:12:39 -07:00
1.36_wmf.18-ParserOutput-cacheTime.json Hard-deprecate all public property access on CacheTime and ParserOutput. 2021-10-13 13:27:16 -04:00
1.36_wmf.18-ParserOutput-cacheTime.serialized Hard-deprecate all public property access on CacheTime and ParserOutput. 2021-10-13 13:27:16 -04:00
1.38-CacheTime-cacheExpiry.serialized Hard-deprecate all public property access on CacheTime and ParserOutput. 2021-10-13 13:27:16 -04:00
1.38-CacheTime-cacheRevisionId.serialized Hard-deprecate all public property access on CacheTime and ParserOutput. 2021-10-13 13:27:16 -04:00
1.38-CacheTime-cacheTime.serialized Hard-deprecate all public property access on CacheTime and ParserOutput. 2021-10-13 13:27:16 -04:00
1.38-CacheTime-empty.serialized Hard-deprecate all public property access on CacheTime and ParserOutput. 2021-10-13 13:27:16 -04:00
1.38-CacheTime-usedOptions.serialized Hard-deprecate all public property access on CacheTime and ParserOutput. 2021-10-13 13:27:16 -04:00
1.38-ParserOutput-binaryPageProperties.json Reapply "Move limit report rendering to ParserOutput" 2021-11-09 11:08:08 -08:00
1.38-ParserOutput-binaryPageProperties.serialized Reapply "Move limit report rendering to ParserOutput" 2021-11-09 11:08:08 -08:00
1.38-ParserOutput-cacheTime.json Reapply "Move limit report rendering to ParserOutput" 2021-11-09 11:08:08 -08:00
1.38-ParserOutput-cacheTime.serialized Reapply "Move limit report rendering to ParserOutput" 2021-11-09 11:08:08 -08:00
1.38-ParserOutput-empty.json Reapply "Move limit report rendering to ParserOutput" 2021-11-09 11:08:08 -08:00
1.38-ParserOutput-empty.serialized Reapply "Move limit report rendering to ParserOutput" 2021-11-09 11:08:08 -08:00
1.38-ParserOutput-extensionData.json Reapply "Move limit report rendering to ParserOutput" 2021-11-09 11:08:08 -08:00
1.38-ParserOutput-extensionData.serialized Reapply "Move limit report rendering to ParserOutput" 2021-11-09 11:08:08 -08:00
1.38-ParserOutput-pageProperties.json Reapply "Move limit report rendering to ParserOutput" 2021-11-09 11:08:08 -08:00
1.38-ParserOutput-pageProperties.serialized Reapply "Move limit report rendering to ParserOutput" 2021-11-09 11:08:08 -08:00
1.38-ParserOutput-text.json Reapply "Move limit report rendering to ParserOutput" 2021-11-09 11:08:08 -08:00
1.38-ParserOutput-text.serialized Reapply "Move limit report rendering to ParserOutput" 2021-11-09 11:08:08 -08:00
1.38-ParserOutput-usedOptions.json Reapply "Move limit report rendering to ParserOutput" 2021-11-09 11:08:08 -08:00
1.38-ParserOutput-usedOptions.serialized Reapply "Move limit report rendering to ParserOutput" 2021-11-09 11:08:08 -08:00
1.38-ParserOutput-withFalsyProperties.json Change return value of ParserOutput::getPageProperty() when property is missing 2022-02-18 21:15:58 +00:00
1.38-ParserOutput-withFalsyProperties.serialized Change return value of ParserOutput::getPageProperty() when property is missing 2022-02-18 21:15:58 +00:00
1.38-ParserOutput-withMetadata.json Update ParserCache serialization test cases to use valid category keys 2022-02-17 12:12:53 -05:00
1.38-ParserOutput-withMetadata.serialized Update ParserCache serialization test cases to use valid category keys 2022-02-17 12:12:53 -05:00
1.38-ParserOutput-withMetadataPost1_31.json Reapply "Move limit report rendering to ParserOutput" 2021-11-09 11:08:08 -08:00
1.38-ParserOutput-withMetadataPost1_31.serialized Reapply "Move limit report rendering to ParserOutput" 2021-11-09 11:08:08 -08:00
1.38-ParserOutput-withMetadataPost1_34.json Reapply "Move limit report rendering to ParserOutput" 2021-11-09 11:08:08 -08:00
1.38-ParserOutput-withMetadataPost1_34.serialized Reapply "Move limit report rendering to ParserOutput" 2021-11-09 11:08:08 -08:00