wiki.techinc.nl/tests/phpunit/structure
Thiemo Kreuz 8c33a391a0 Fix assertArrayEquals() calls with bogus 3rd parameter
This issue came up in I8a49143, see
https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-postgres-php70-docker/2453/console
The third parameter of assertArrayEquals() is called $ordered and is
meant to take the order of elements into account. Providing a string sets
this to true. The SQL query in ChangesListSpecialPageTest seems to behave
a bit random in Postgres and does not always return the elements in the
same order. This is fine. It's just the assertion that was to strict, by
accident.

I found a few more instances of the same issue with a regular expression.
In most cases I intentionally changed it to assertSame() because the order
of elements is actually guaranteed by the code, and needs to be (e.g.
mixing width and height of an image would be fatal).

Change-Id: Ice66cab873a7271d55809a486ce28cf637e43e33
2019-03-14 18:02:08 +01:00
..
ApiPrefixUniquenessTest.php test: Assert that API generators have unique prefixes 2018-08-17 17:31:22 -07:00
ApiStructureTest.php Add @coversNothing for left over tests and enable sniff 2019-02-02 21:53:40 -08:00
AutoLoaderStructureTest.php Remove array_unique() on expected classes in checkAutoLoadConf() 2018-11-30 00:22:06 +00:00
AvailableRightsTest.php Check for right-* messages as a structure test 2018-07-26 14:14:54 -07:00
ContentHandlerSanityTest.php Add @coversNothing to tests that don't cover specific PHP classes 2018-06-12 13:27:40 -07:00
DatabaseIntegrationTest.php Add @coversNothing for left over tests and enable sniff 2019-02-02 21:53:40 -08:00
ExtensionJsonValidationTest.php Add @coversNothing to tests that don't cover specific PHP classes 2018-06-12 13:27:40 -07:00
PasswordPolicyStructureTest.php Add password policy setting suggestChangeOnLogin 2019-03-09 14:59:02 -05:00
ResourcesTest.php Fix assertArrayEquals() calls with bogus 3rd parameter 2019-03-14 18:02:08 +01:00
SpecialPageFatalTest.php Add @coversNothing for left over tests and enable sniff 2019-02-02 21:53:40 -08:00
StructureTest.php StructureTest::testUnitTestFileNamesEndWithTest() should not shell out 2018-09-18 20:34:28 +02:00