Parameter validation is based on parameter definitions like those in the Action API, using the new ParamValidator library. Handlers should use the provided Handler methods to access parameters rather than fetching them directly from the RequestInterface. Body validation allows the handler to have the (non-form-data) body of a request parsed and validated. The only validator included in this patch ignores the body entirely; future patches may implement validation for JSON bodies based on JSON schemas, or the like. Bug: T223239 Change-Id: I3c37ea2b432840514b6bff90007c8403989225d5
93 lines
2.5 KiB
PHP
93 lines
2.5 KiB
PHP
<?php
|
|
|
|
namespace MediaWiki\Tests\Rest\Handler;
|
|
|
|
use EmptyBagOStuff;
|
|
use GuzzleHttp\Psr7\Uri;
|
|
use MediaWiki\Rest\BasicAccess\StaticBasicAuthorizer;
|
|
use MediaWiki\Rest\RequestData;
|
|
use MediaWiki\Rest\ResponseFactory;
|
|
use MediaWiki\Rest\Router;
|
|
use MediaWiki\Rest\Validator\Validator;
|
|
use Psr\Container\ContainerInterface;
|
|
use Wikimedia\ObjectFactory;
|
|
use User;
|
|
|
|
/**
|
|
* @covers \MediaWiki\Rest\Handler\HelloHandler
|
|
*/
|
|
class HelloHandlerTest extends \MediaWikiUnitTestCase {
|
|
public static function provideTestViaRouter() {
|
|
return [
|
|
'normal' => [
|
|
[
|
|
'method' => 'GET',
|
|
'uri' => self::makeUri( '/user/Tim/hello' ),
|
|
],
|
|
[
|
|
'statusCode' => 200,
|
|
'reasonPhrase' => 'OK',
|
|
'protocolVersion' => '1.1',
|
|
'body' => '{"message":"Hello, Tim!"}',
|
|
],
|
|
],
|
|
'method not allowed' => [
|
|
[
|
|
'method' => 'POST',
|
|
'uri' => self::makeUri( '/user/Tim/hello' ),
|
|
],
|
|
[
|
|
'statusCode' => 405,
|
|
'reasonPhrase' => 'Method Not Allowed',
|
|
'protocolVersion' => '1.1',
|
|
'body' => '{"httpCode":405,"httpReason":"Method Not Allowed"}',
|
|
],
|
|
],
|
|
];
|
|
}
|
|
|
|
private static function makeUri( $path ) {
|
|
return new Uri( "http://www.example.com/rest$path" );
|
|
}
|
|
|
|
/** @dataProvider provideTestViaRouter */
|
|
public function testViaRouter( $requestInfo, $responseInfo ) {
|
|
$objectFactory = new ObjectFactory(
|
|
$this->getMockForAbstractClass( ContainerInterface::class )
|
|
);
|
|
|
|
$request = new RequestData( $requestInfo );
|
|
$router = new Router(
|
|
[ __DIR__ . '/../testRoutes.json' ],
|
|
[],
|
|
'/rest',
|
|
new EmptyBagOStuff(),
|
|
new ResponseFactory(),
|
|
new StaticBasicAuthorizer(),
|
|
$objectFactory,
|
|
new Validator( $objectFactory, $request, new User )
|
|
);
|
|
$response = $router->execute( $request );
|
|
if ( isset( $responseInfo['statusCode'] ) ) {
|
|
$this->assertSame( $responseInfo['statusCode'], $response->getStatusCode() );
|
|
}
|
|
if ( isset( $responseInfo['reasonPhrase'] ) ) {
|
|
$this->assertSame( $responseInfo['reasonPhrase'], $response->getReasonPhrase() );
|
|
}
|
|
if ( isset( $responseInfo['protocolVersion'] ) ) {
|
|
$this->assertSame( $responseInfo['protocolVersion'], $response->getProtocolVersion() );
|
|
}
|
|
if ( isset( $responseInfo['body'] ) ) {
|
|
$this->assertSame( $responseInfo['body'], $response->getBody()->getContents() );
|
|
}
|
|
$this->assertSame(
|
|
[],
|
|
array_diff( array_keys( $responseInfo ), [
|
|
'statusCode',
|
|
'reasonPhrase',
|
|
'protocolVersion',
|
|
'body'
|
|
] ),
|
|
'$responseInfo may not contain unknown keys' );
|
|
}
|
|
}
|