wiki.techinc.nl/tests/phpunit/includes/Storage/MutableRevisionSlotsTest.php
daniel e8632ab0f6 [MCR] Factor PageUpdater out of WikiPage
This introduces PageUpdater to replace WikiPage::doEditContent,
and DerivedPageDataUpdater, to replace WikiPage::doEditUpdates
and WikiPage::prepareContentForEdit.

See docs/pageupdater.txt for a description of their
functionality.

MCR migration notes:

* The interface of PageUpdater is expected to
remain mostly stable after this patch. Code that has been using
WikiPage::doEditContent can be confidently migrated to using the
new mechanism for revision creation.

* This patch keeps the code inside PageUpdater largely aligned
with the old code in WikiPage, to make review easier to to avoid
mistakes. It is intended to be refactored further, moving
application logic into stateless services.

* DerivedPageDataUpdate is intended as a stepping stone for further
refactoring. Its behavior is designed to be compatible with
callback code that currently relies on
WikiPage::prepareContentForEdit. Much of the code that currently
lives in DerivedPageDataUpdate should be factored out into
services, all behavior relevant to calling code should be exposed
via narrow interfaces.

Bug: T174038
Bug: T196653
Change-Id: If610c68f4912e89af616cdcac1d35a1be3946afa
2018-06-14 13:22:13 +00:00

148 lines
5.2 KiB
PHP

<?php
namespace MediaWiki\Tests\Storage;
use Content;
use InvalidArgumentException;
use MediaWiki\Storage\MutableRevisionSlots;
use MediaWiki\Storage\RevisionAccessException;
use MediaWiki\Storage\RevisionSlots;
use MediaWiki\Storage\SlotRecord;
use WikitextContent;
/**
* @covers \MediaWiki\Storage\MutableRevisionSlots
*/
class MutableRevisionSlotsTest extends RevisionSlotsTest {
/**
* @param SlotRecord[] $slots
* @return RevisionSlots
*/
protected function newRevisionSlots( $slots = [] ) {
return new MutableRevisionSlots( $slots );
}
public function provideConstructorFailue() {
yield 'array or the wrong thing' => [
[ 1, 2, 3 ]
];
}
/**
* @dataProvider provideConstructorFailue
* @param $slots
*
* @covers \MediaWiki\Storage\RevisionSlots::__construct
* @covers \MediaWiki\Storage\RevisionSlots::setSlotsInternal
*/
public function testConstructorFailue( $slots ) {
$this->setExpectedException( InvalidArgumentException::class );
new MutableRevisionSlots( $slots );
}
public function testSetMultipleSlots() {
$slots = new MutableRevisionSlots();
$this->assertSame( [], $slots->getSlots() );
$slotA = SlotRecord::newUnsaved( 'some', new WikitextContent( 'A' ) );
$slots->setSlot( $slotA );
$this->assertTrue( $slots->hasSlot( 'some' ) );
$this->assertSame( $slotA, $slots->getSlot( 'some' ) );
$this->assertSame( [ 'some' => $slotA ], $slots->getSlots() );
$slotB = SlotRecord::newUnsaved( 'other', new WikitextContent( 'B' ) );
$slots->setSlot( $slotB );
$this->assertTrue( $slots->hasSlot( 'other' ) );
$this->assertSame( $slotB, $slots->getSlot( 'other' ) );
$this->assertSame( [ 'some' => $slotA, 'other' => $slotB ], $slots->getSlots() );
}
public function testSetExistingSlotOverwritesSlot() {
$slots = new MutableRevisionSlots();
$this->assertSame( [], $slots->getSlots() );
$slotA = SlotRecord::newUnsaved( 'main', new WikitextContent( 'A' ) );
$slots->setSlot( $slotA );
$this->assertSame( $slotA, $slots->getSlot( 'main' ) );
$this->assertSame( [ 'main' => $slotA ], $slots->getSlots() );
$slotB = SlotRecord::newUnsaved( 'main', new WikitextContent( 'B' ) );
$slots->setSlot( $slotB );
$this->assertSame( $slotB, $slots->getSlot( 'main' ) );
$this->assertSame( [ 'main' => $slotB ], $slots->getSlots() );
}
/**
* @param string $role
* @param Content $content
* @return SlotRecord
*/
private function newSavedSlot( $role, Content $content ) {
return SlotRecord::newSaved( 7, 7, 'xyz', SlotRecord::newUnsaved( $role, $content ) );
}
public function testInheritSlotOverwritesSlot() {
$slots = new MutableRevisionSlots();
$slotA = SlotRecord::newUnsaved( 'main', new WikitextContent( 'A' ) );
$slots->setSlot( $slotA );
$slotB = $this->newSavedSlot( 'main', new WikitextContent( 'B' ) );
$slotC = $this->newSavedSlot( 'foo', new WikitextContent( 'C' ) );
$slots->inheritSlot( $slotB );
$slots->inheritSlot( $slotC );
$this->assertSame( [ 'main', 'foo' ], $slots->getSlotRoles() );
$this->assertNotSame( $slotB, $slots->getSlot( 'main' ) );
$this->assertNotSame( $slotC, $slots->getSlot( 'foo' ) );
$this->assertTrue( $slots->getSlot( 'main' )->isInherited() );
$this->assertTrue( $slots->getSlot( 'foo' )->isInherited() );
$this->assertSame( $slotB->getContent(), $slots->getSlot( 'main' )->getContent() );
$this->assertSame( $slotC->getContent(), $slots->getSlot( 'foo' )->getContent() );
}
public function testSetContentOfExistingSlotOverwritesContent() {
$slots = new MutableRevisionSlots();
$this->assertSame( [], $slots->getSlots() );
$slotA = SlotRecord::newUnsaved( 'main', new WikitextContent( 'A' ) );
$slots->setSlot( $slotA );
$this->assertSame( $slotA, $slots->getSlot( 'main' ) );
$this->assertSame( [ 'main' => $slotA ], $slots->getSlots() );
$newContent = new WikitextContent( 'B' );
$slots->setContent( 'main', $newContent );
$this->assertSame( $newContent, $slots->getContent( 'main' ) );
}
public function testRemoveExistingSlot() {
$slotA = SlotRecord::newUnsaved( 'main', new WikitextContent( 'A' ) );
$slots = new MutableRevisionSlots( [ $slotA ] );
$this->assertSame( [ 'main' => $slotA ], $slots->getSlots() );
$slots->removeSlot( 'main' );
$this->assertSame( [], $slots->getSlots() );
$this->setExpectedException( RevisionAccessException::class );
$slots->getSlot( 'main' );
}
public function testNewFromParentRevisionSlots() {
/** @var SlotRecord[] $parentSlots */
$parentSlots = [
'some' => $this->newSavedSlot( 'some', new WikitextContent( 'X' ) ),
'other' => $this->newSavedSlot( 'other', new WikitextContent( 'Y' ) ),
];
$slots = MutableRevisionSlots::newFromParentRevisionSlots( $parentSlots );
$this->assertSame( [ 'some', 'other' ], $slots->getSlotRoles() );
$this->assertNotSame( $parentSlots['some'], $slots->getSlot( 'some' ) );
$this->assertNotSame( $parentSlots['other'], $slots->getSlot( 'other' ) );
$this->assertTrue( $slots->getSlot( 'some' )->isInherited() );
$this->assertTrue( $slots->getSlot( 'other' )->isInherited() );
$this->assertSame( $parentSlots['some']->getContent(), $slots->getContent( 'some' ) );
$this->assertSame( $parentSlots['other']->getContent(), $slots->getContent( 'other' ) );
}
}