bca6085920
I wasn't sure how to convert the rest of the occurrences in core (there are a significant number). Bug: T200881 Change-Id: I114bba946cd3ea8a293121e275588c3c4d174f94
55 lines
2 KiB
PHP
55 lines
2 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @covers ParserFactory
|
|
*/
|
|
class ParserFactoryTest extends MediaWikiTestCase {
|
|
/**
|
|
* For backwards compatibility, all parameters to the parser constructor are optional and
|
|
* default to the appropriate global service, so it's easy to forget to update ParserFactory to
|
|
* actually pass the parameters it's supposed to.
|
|
*/
|
|
public function testConstructorArgNum() {
|
|
$factoryConstructor = new ReflectionMethod( 'ParserFactory', '__construct' );
|
|
$instanceConstructor = new ReflectionMethod( 'Parser', '__construct' );
|
|
// Subtract one for the ParserFactory itself
|
|
$this->assertSame( $instanceConstructor->getNumberOfParameters() - 1,
|
|
$factoryConstructor->getNumberOfParameters(),
|
|
'Parser and ParserFactory constructors have an inconsistent number of parameters. ' .
|
|
'Did you add a parameter to one and not the other?' );
|
|
}
|
|
|
|
public function testAllArgumentsWerePassed() {
|
|
$factoryConstructor = new ReflectionMethod( 'ParserFactory', '__construct' );
|
|
$mocks = [];
|
|
foreach ( $factoryConstructor->getParameters() as $param ) {
|
|
$type = (string)$param->getType();
|
|
if ( $type === 'array' ) {
|
|
$val = [ 'porcupines will tell me your secrets' . count( $mocks ) ];
|
|
} elseif ( class_exists( $type ) || interface_exists( $type ) ) {
|
|
$val = $this->createMock( $type );
|
|
} elseif ( $type === '' ) {
|
|
// Optimistically assume a string is okay
|
|
$val = 'I will de-quill them first' . count( $mocks );
|
|
} else {
|
|
$this->fail( "Unrecognized parameter type $type in ParserFactory constructor" );
|
|
}
|
|
$mocks[] = $val;
|
|
}
|
|
|
|
$factory = new ParserFactory( ...$mocks );
|
|
$parser = $factory->create();
|
|
|
|
foreach ( ( new ReflectionObject( $parser ) )->getProperties() as $prop ) {
|
|
$prop->setAccessible( true );
|
|
foreach ( $mocks as $idx => $mock ) {
|
|
if ( $prop->getValue( $parser ) === $mock ) {
|
|
unset( $mocks[$idx] );
|
|
}
|
|
}
|
|
}
|
|
|
|
$this->assertCount( 0, $mocks, 'Not all arguments to the ParserFactory constructor were ' .
|
|
'found in Parser member variables' );
|
|
}
|
|
}
|