fb73286fba
Instead of having basically every caller do: $pf = new PasswordFactory(); $pf->init( RequestContext::getMain()->getConfig() ); Just create a single PasswordFactory via MediaWikiServices and pass that around. Things that want to use their own config can still pass settings via the new constructor. This will eventually let us remove the init() function, removing the only hard dependency upon MediaWiki, to make it easier to librarize (T89742). Change-Id: I0fc7520dc023b11a7fa66083eff7b88ebfe49c7b
124 lines
3.9 KiB
PHP
124 lines
3.9 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @covers PasswordFactory
|
|
*/
|
|
class PasswordFactoryTest extends MediaWikiTestCase {
|
|
public function testConstruct() {
|
|
$pf = new PasswordFactory();
|
|
$this->assertEquals( [ '' ], array_keys( $pf->getTypes() ) );
|
|
$this->assertEquals( '', $pf->getDefaultType() );
|
|
|
|
$pf = new PasswordFactory( [
|
|
'foo' => [ 'class' => 'FooPassword' ],
|
|
'bar' => [ 'class' => 'BarPassword', 'baz' => 'boom' ],
|
|
], 'foo' );
|
|
$this->assertEquals( [ '', 'foo', 'bar' ], array_keys( $pf->getTypes() ) );
|
|
$this->assertArraySubset( [ 'class' => 'BarPassword', 'baz' => 'boom' ], $pf->getTypes()['bar'] );
|
|
$this->assertEquals( 'foo', $pf->getDefaultType() );
|
|
}
|
|
|
|
public function testRegister() {
|
|
$pf = new PasswordFactory;
|
|
$pf->register( 'foo', [ 'class' => InvalidPassword::class ] );
|
|
$this->assertArrayHasKey( 'foo', $pf->getTypes() );
|
|
}
|
|
|
|
public function testSetDefaultType() {
|
|
$pf = new PasswordFactory;
|
|
$pf->register( '1', [ 'class' => InvalidPassword::class ] );
|
|
$pf->register( '2', [ 'class' => InvalidPassword::class ] );
|
|
$pf->setDefaultType( '1' );
|
|
$this->assertSame( '1', $pf->getDefaultType() );
|
|
$pf->setDefaultType( '2' );
|
|
$this->assertSame( '2', $pf->getDefaultType() );
|
|
}
|
|
|
|
/**
|
|
* @expectedException Exception
|
|
*/
|
|
public function testSetDefaultTypeError() {
|
|
$pf = new PasswordFactory;
|
|
$pf->setDefaultType( 'bogus' );
|
|
}
|
|
|
|
public function testInit() {
|
|
$config = new HashConfig( [
|
|
'PasswordConfig' => [
|
|
'foo' => [ 'class' => InvalidPassword::class ],
|
|
],
|
|
'PasswordDefault' => 'foo'
|
|
] );
|
|
$pf = new PasswordFactory;
|
|
$pf->init( $config );
|
|
$this->assertSame( 'foo', $pf->getDefaultType() );
|
|
$this->assertArrayHasKey( 'foo', $pf->getTypes() );
|
|
}
|
|
|
|
public function testNewFromCiphertext() {
|
|
$pf = new PasswordFactory;
|
|
$pf->register( 'B', [ 'class' => MWSaltedPassword::class ] );
|
|
$pw = $pf->newFromCiphertext( ':B:salt:d529e941509eb9e9b9cfaeae1fe7ca23' );
|
|
$this->assertInstanceOf( MWSaltedPassword::class, $pw );
|
|
}
|
|
|
|
public function provideNewFromCiphertextErrors() {
|
|
return [ [ 'blah' ], [ ':blah:' ] ];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideNewFromCiphertextErrors
|
|
* @expectedException PasswordError
|
|
*/
|
|
public function testNewFromCiphertextErrors( $hash ) {
|
|
$pf = new PasswordFactory;
|
|
$pf->register( 'B', [ 'class' => MWSaltedPassword::class ] );
|
|
$pf->newFromCiphertext( $hash );
|
|
}
|
|
|
|
public function testNewFromType() {
|
|
$pf = new PasswordFactory;
|
|
$pf->register( 'B', [ 'class' => MWSaltedPassword::class ] );
|
|
$pw = $pf->newFromType( 'B' );
|
|
$this->assertInstanceOf( MWSaltedPassword::class, $pw );
|
|
}
|
|
|
|
/**
|
|
* @expectedException PasswordError
|
|
*/
|
|
public function testNewFromTypeError() {
|
|
$pf = new PasswordFactory;
|
|
$pf->register( 'B', [ 'class' => MWSaltedPassword::class ] );
|
|
$pf->newFromType( 'bogus' );
|
|
}
|
|
|
|
public function testNewFromPlaintext() {
|
|
$pf = new PasswordFactory;
|
|
$pf->register( 'A', [ 'class' => MWOldPassword::class ] );
|
|
$pf->register( 'B', [ 'class' => MWSaltedPassword::class ] );
|
|
$pf->setDefaultType( 'A' );
|
|
|
|
$this->assertInstanceOf( InvalidPassword::class, $pf->newFromPlaintext( null ) );
|
|
$this->assertInstanceOf( MWOldPassword::class, $pf->newFromPlaintext( 'password' ) );
|
|
$this->assertInstanceOf( MWSaltedPassword::class,
|
|
$pf->newFromPlaintext( 'password', $pf->newFromType( 'B' ) ) );
|
|
}
|
|
|
|
public function testNeedsUpdate() {
|
|
$pf = new PasswordFactory;
|
|
$pf->register( 'A', [ 'class' => MWOldPassword::class ] );
|
|
$pf->register( 'B', [ 'class' => MWSaltedPassword::class ] );
|
|
$pf->setDefaultType( 'A' );
|
|
|
|
$this->assertFalse( $pf->needsUpdate( $pf->newFromType( 'A' ) ) );
|
|
$this->assertTrue( $pf->needsUpdate( $pf->newFromType( 'B' ) ) );
|
|
}
|
|
|
|
public function testGenerateRandomPasswordString() {
|
|
$this->assertSame( 13, strlen( PasswordFactory::generateRandomPasswordString( 13 ) ) );
|
|
}
|
|
|
|
public function testNewInvalidPassword() {
|
|
$this->assertInstanceOf( InvalidPassword::class, PasswordFactory::newInvalidPassword() );
|
|
}
|
|
}
|