The default will remain PHPUnit 4.x due to PHP 5.5 support. But, we should allow developers to run tests with newer PHPUnit versions which are noticably faster (especially for code coverage reports). * <https://github.com/sebastianbergmann/phpunit/wiki/Release-Announcement-for-PHPUnit-5.4.0> PHPUnit 5 deprecates the getMock() shortcut for getMockBuilder()->getMock(). It instead introduces the shortcut createMock() which has better defaults than getMockBuilder(). For example, it sets 'disableArgumentCloning' and other things by default. Going forward, code should either use getMockBuilder directly and configure it using the setter methods (instead of the confusing variadic arguments of getMock) or simply use the new minimalistic createMock method. This patch backports the createMock method to MediaWikiTestCase so that we can start using it. Change-Id: I091c0289b21d2b1c876adba89529dc3e72b99af2
199 lines
5.9 KiB
PHP
199 lines
5.9 KiB
PHP
<?php
|
|
|
|
/**
|
|
* Tests for the SiteImporter class.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
*
|
|
* @ingroup Site
|
|
* @ingroup Test
|
|
*
|
|
* @group Site
|
|
*
|
|
* @covers SiteImporter
|
|
*
|
|
* @author Daniel Kinzler
|
|
*/
|
|
class SiteImporterTest extends PHPUnit_Framework_TestCase {
|
|
|
|
private function newSiteImporter( array $expectedSites, $errorCount ) {
|
|
$store = $this->getMockBuilder( 'SiteStore' )->getMock();
|
|
|
|
$store->expects( $this->once() )
|
|
->method( 'saveSites' )
|
|
->will( $this->returnCallback( function ( $sites ) use ( $expectedSites ) {
|
|
$this->assertSitesEqual( $expectedSites, $sites );
|
|
} ) );
|
|
|
|
$store->expects( $this->any() )
|
|
->method( 'getSites' )
|
|
->will( $this->returnValue( new SiteList() ) );
|
|
|
|
$errorHandler = $this->getMockBuilder( 'Psr\Log\LoggerInterface' )->getMock();
|
|
$errorHandler->expects( $this->exactly( $errorCount ) )
|
|
->method( 'error' );
|
|
|
|
$importer = new SiteImporter( $store );
|
|
$importer->setExceptionCallback( [ $errorHandler, 'error' ] );
|
|
|
|
return $importer;
|
|
}
|
|
|
|
public function assertSitesEqual( $expected, $actual, $message = '' ) {
|
|
$this->assertEquals(
|
|
$this->getSerializedSiteList( $expected ),
|
|
$this->getSerializedSiteList( $actual ),
|
|
$message
|
|
);
|
|
}
|
|
|
|
public function provideImportFromXML() {
|
|
$foo = Site::newForType( Site::TYPE_UNKNOWN );
|
|
$foo->setGlobalId( 'Foo' );
|
|
|
|
$acme = Site::newForType( Site::TYPE_UNKNOWN );
|
|
$acme->setGlobalId( 'acme.com' );
|
|
$acme->setGroup( 'Test' );
|
|
$acme->addLocalId( Site::ID_INTERWIKI, 'acme' );
|
|
$acme->setPath( Site::PATH_LINK, 'http://acme.com/' );
|
|
|
|
$dewiki = Site::newForType( Site::TYPE_MEDIAWIKI );
|
|
$dewiki->setGlobalId( 'dewiki' );
|
|
$dewiki->setGroup( 'wikipedia' );
|
|
$dewiki->setForward( true );
|
|
$dewiki->addLocalId( Site::ID_INTERWIKI, 'wikipedia' );
|
|
$dewiki->addLocalId( Site::ID_EQUIVALENT, 'de' );
|
|
$dewiki->setPath( Site::PATH_LINK, 'http://de.wikipedia.org/w/' );
|
|
$dewiki->setPath( MediaWikiSite::PATH_PAGE, 'http://de.wikipedia.org/wiki/' );
|
|
$dewiki->setSource( 'meta.wikimedia.org' );
|
|
|
|
return [
|
|
'empty' => [
|
|
'<sites></sites>',
|
|
[],
|
|
],
|
|
'no sites' => [
|
|
'<sites><Foo><globalid>Foo</globalid></Foo><Bar><quux>Bla</quux></Bar></sites>',
|
|
[],
|
|
],
|
|
'minimal' => [
|
|
'<sites>' .
|
|
'<site><globalid>Foo</globalid></site>' .
|
|
'</sites>',
|
|
[ $foo ],
|
|
],
|
|
'full' => [
|
|
'<sites>' .
|
|
'<site><globalid>Foo</globalid></site>' .
|
|
'<site>' .
|
|
'<globalid>acme.com</globalid>' .
|
|
'<localid type="interwiki">acme</localid>' .
|
|
'<group>Test</group>' .
|
|
'<path type="link">http://acme.com/</path>' .
|
|
'</site>' .
|
|
'<site type="mediawiki">' .
|
|
'<source>meta.wikimedia.org</source>' .
|
|
'<globalid>dewiki</globalid>' .
|
|
'<localid type="interwiki">wikipedia</localid>' .
|
|
'<localid type="equivalent">de</localid>' .
|
|
'<group>wikipedia</group>' .
|
|
'<forward/>' .
|
|
'<path type="link">http://de.wikipedia.org/w/</path>' .
|
|
'<path type="page_path">http://de.wikipedia.org/wiki/</path>' .
|
|
'</site>' .
|
|
'</sites>',
|
|
[ $foo, $acme, $dewiki ],
|
|
],
|
|
'skip' => [
|
|
'<sites>' .
|
|
'<site><globalid>Foo</globalid></site>' .
|
|
'<site><barf>Foo</barf></site>' .
|
|
'<site>' .
|
|
'<globalid>acme.com</globalid>' .
|
|
'<localid type="interwiki">acme</localid>' .
|
|
'<silly>boop!</silly>' .
|
|
'<group>Test</group>' .
|
|
'<path type="link">http://acme.com/</path>' .
|
|
'</site>' .
|
|
'</sites>',
|
|
[ $foo, $acme ],
|
|
1
|
|
],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideImportFromXML
|
|
*/
|
|
public function testImportFromXML( $xml, array $expectedSites, $errorCount = 0 ) {
|
|
$importer = $this->newSiteImporter( $expectedSites, $errorCount );
|
|
$importer->importFromXML( $xml );
|
|
}
|
|
|
|
public function testImportFromXML_malformed() {
|
|
$this->setExpectedException( 'Exception' );
|
|
|
|
$store = $this->getMockBuilder( 'SiteStore' )->getMock();
|
|
$importer = new SiteImporter( $store );
|
|
$importer->importFromXML( 'THIS IS NOT XML' );
|
|
}
|
|
|
|
public function testImportFromFile() {
|
|
$foo = Site::newForType( Site::TYPE_UNKNOWN );
|
|
$foo->setGlobalId( 'Foo' );
|
|
|
|
$acme = Site::newForType( Site::TYPE_UNKNOWN );
|
|
$acme->setGlobalId( 'acme.com' );
|
|
$acme->setGroup( 'Test' );
|
|
$acme->addLocalId( Site::ID_INTERWIKI, 'acme' );
|
|
$acme->setPath( Site::PATH_LINK, 'http://acme.com/' );
|
|
|
|
$dewiki = Site::newForType( Site::TYPE_MEDIAWIKI );
|
|
$dewiki->setGlobalId( 'dewiki' );
|
|
$dewiki->setGroup( 'wikipedia' );
|
|
$dewiki->setForward( true );
|
|
$dewiki->addLocalId( Site::ID_INTERWIKI, 'wikipedia' );
|
|
$dewiki->addLocalId( Site::ID_EQUIVALENT, 'de' );
|
|
$dewiki->setPath( Site::PATH_LINK, 'http://de.wikipedia.org/w/' );
|
|
$dewiki->setPath( MediaWikiSite::PATH_PAGE, 'http://de.wikipedia.org/wiki/' );
|
|
$dewiki->setSource( 'meta.wikimedia.org' );
|
|
|
|
$importer = $this->newSiteImporter( [ $foo, $acme, $dewiki ], 0 );
|
|
|
|
$file = __DIR__ . '/SiteImporterTest.xml';
|
|
$importer->importFromFile( $file );
|
|
}
|
|
|
|
/**
|
|
* @param Site[] $sites
|
|
*
|
|
* @return array[]
|
|
*/
|
|
private function getSerializedSiteList( $sites ) {
|
|
$serialized = [];
|
|
|
|
foreach ( $sites as $site ) {
|
|
$key = $site->getGlobalId();
|
|
$data = unserialize( $site->serialize() );
|
|
|
|
$serialized[$key] = $data;
|
|
}
|
|
|
|
return $serialized;
|
|
}
|
|
}
|