4a1b4aeb2a
This is a follow up to a previous fix in
4079d328e7 which used parse_url()==false
as an indirect test to see if `new Uri()` would throw. Avoid the
indirection and use a try/catch instead to be more robust against
fixes in the Uri library and/or the parse_url() implementation.
Bug: T256831
Bug: T261344
Change-Id: Ia52c5b2c77a4481afd82b468c2f7fb3c05996a91
104 lines
2.5 KiB
PHP
104 lines
2.5 KiB
PHP
<?php
|
|
|
|
namespace MediaWiki\Rest;
|
|
|
|
use GuzzleHttp\Psr7\LazyOpenStream;
|
|
use GuzzleHttp\Psr7\ServerRequest;
|
|
use GuzzleHttp\Psr7\Uri;
|
|
|
|
// phpcs:disable MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals
|
|
|
|
/**
|
|
* This is a request class that gets data directly from the superglobals and
|
|
* other global PHP state, notably php://input.
|
|
*/
|
|
class RequestFromGlobals extends RequestBase {
|
|
private $uri;
|
|
private $protocol;
|
|
private $uploadedFiles;
|
|
|
|
/**
|
|
* @param array $params Associative array of parameters:
|
|
* - cookiePrefix: The prefix for cookie names used by getCookie()
|
|
*/
|
|
public function __construct( $params = [] ) {
|
|
parent::__construct( $params['cookiePrefix'] ?? '' );
|
|
}
|
|
|
|
// RequestInterface
|
|
|
|
public function getMethod() {
|
|
return $_SERVER['REQUEST_METHOD'] ?? 'GET';
|
|
}
|
|
|
|
public function getUri() {
|
|
if ( $this->uri === null ) {
|
|
$requestUrl = \WebRequest::getGlobalRequestURL();
|
|
|
|
try {
|
|
$uriInstance = new Uri( $requestUrl );
|
|
} catch ( \InvalidArgumentException $e ) {
|
|
// Uri constructor will throw exception if the URL is
|
|
// relative and contains colon-number pattern that
|
|
// looks like a port.
|
|
//
|
|
// Since $requestUrl here is absolute-path references
|
|
// so all titles that contain colon followed by a
|
|
// number would be inacessible if the exception occurs.
|
|
$uriInstance = (
|
|
new Uri( '//HOST:80' . $requestUrl )
|
|
)->withScheme( '' )->withHost( '' )->withPort( null );
|
|
}
|
|
$this->uri = $uriInstance;
|
|
}
|
|
return $this->uri;
|
|
}
|
|
|
|
// MessageInterface
|
|
|
|
public function getProtocolVersion() {
|
|
if ( $this->protocol === null ) {
|
|
$serverProtocol = $_SERVER['SERVER_PROTOCOL'] ?? '';
|
|
$prefixLength = strlen( 'HTTP/' );
|
|
if ( strncmp( $serverProtocol, 'HTTP/', $prefixLength ) === 0 ) {
|
|
$this->protocol = substr( $serverProtocol, $prefixLength );
|
|
} else {
|
|
$this->protocol = '1.1';
|
|
}
|
|
}
|
|
return $this->protocol;
|
|
}
|
|
|
|
protected function initHeaders() {
|
|
$this->setHeaders( getallheaders() );
|
|
}
|
|
|
|
public function getBody() {
|
|
return new LazyOpenStream( 'php://input', 'r' );
|
|
}
|
|
|
|
// ServerRequestInterface
|
|
|
|
public function getServerParams() {
|
|
return $_SERVER;
|
|
}
|
|
|
|
public function getCookieParams() {
|
|
return $_COOKIE;
|
|
}
|
|
|
|
public function getQueryParams() {
|
|
return $_GET;
|
|
}
|
|
|
|
public function getUploadedFiles() {
|
|
if ( $this->uploadedFiles === null ) {
|
|
$this->uploadedFiles = ServerRequest::normalizeFiles( $_FILES );
|
|
}
|
|
return $this->uploadedFiles;
|
|
}
|
|
|
|
public function getPostParams() {
|
|
return $_POST;
|
|
}
|
|
}
|