wiki.techinc.nl/includes/logging/LegacyLogFormatter.php
Tim Starling 68c433bd23 Hooks::run() call site migration
Migrate all callers of Hooks::run() to use the new
HookContainer/HookRunner system.

General principles:
* Use DI if it is already used. We're not changing the way state is
  managed in this patch.
* HookContainer is always injected, not HookRunner. HookContainer
  is a service, it's a more generic interface, it is the only
  thing that provides isRegistered() which is needed in some cases,
  and a HookRunner can be efficiently constructed from it
  (confirmed by benchmark). Because HookContainer is needed
  for object construction, it is also needed by all factories.
* "Ask your friendly local base class". Big hierarchies like
  SpecialPage and ApiBase have getHookContainer() and getHookRunner()
  methods in the base class, and classes that extend that base class
  are not expected to know or care where the base class gets its
  HookContainer from.
* ProtectedHookAccessorTrait provides protected getHookContainer() and
  getHookRunner() methods, getting them from the global service
  container. The point of this is to ease migration to DI by ensuring
  that call sites ask their local friendly base class rather than
  getting a HookRunner from the service container directly.
* Private $this->hookRunner. In some smaller classes where accessor
  methods did not seem warranted, there is a private HookRunner property
  which is accessed directly. Very rarely (two cases), there is a
  protected property, for consistency with code that conventionally
  assumes protected=private, but in cases where the class might actually
  be overridden, a protected accessor is preferred over a protected
  property.
* The last resort: Hooks::runner(). Mostly for static, file-scope and
  global code. In a few cases it was used for objects with broken
  construction schemes, out of horror or laziness.

Constructors with new required arguments:
* AuthManager
* BadFileLookup
* BlockManager
* ClassicInterwikiLookup
* ContentHandlerFactory
* ContentSecurityPolicy
* DefaultOptionsManager
* DerivedPageDataUpdater
* FullSearchResultWidget
* HtmlCacheUpdater
* LanguageFactory
* LanguageNameUtils
* LinkRenderer
* LinkRendererFactory
* LocalisationCache
* MagicWordFactory
* MessageCache
* NamespaceInfo
* PageEditStash
* PageHandlerFactory
* PageUpdater
* ParserFactory
* PermissionManager
* RevisionStore
* RevisionStoreFactory
* SearchEngineConfig
* SearchEngineFactory
* SearchFormWidget
* SearchNearMatcher
* SessionBackend
* SpecialPageFactory
* UserNameUtils
* UserOptionsManager
* WatchedItemQueryService
* WatchedItemStore

Constructors with new optional arguments:
* DefaultPreferencesFactory
* Language
* LinkHolderArray
* MovePage
* Parser
* ParserCache
* PasswordReset
* Router

setHookContainer() now required after construction:
* AuthenticationProvider
* ResourceLoaderModule
* SearchEngine

Change-Id: Id442b0dbe43aba84bd5cf801d86dedc768b082c7
2020-05-30 14:23:28 +00:00

127 lines
3.7 KiB
PHP

<?php
/**
* Contains a class for formatting log legacy entries
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*
* @file
* @author Niklas Laxström
* @license GPL-2.0-or-later
* @since 1.19
*/
/**
* This class formats all log entries for log types
* which have not been converted to the new system.
* This is not about old log entries which store
* parameters in a different format - the new
* LogFormatter classes have code to support formatting
* those too.
* @since 1.19
*/
class LegacyLogFormatter extends LogFormatter {
/**
* Backward compatibility for extension changing the comment from
* the LogLine hook. This will be set by the first call on getComment(),
* then it might be modified by the hook when calling getActionLinks(),
* so that the modified value will be returned when calling getComment()
* a second time.
*
* @var string|null
*/
private $comment = null;
/**
* Cache for the result of getActionLinks() so that it does not need to
* run multiple times depending on the order that getComment() and
* getActionLinks() are called.
*
* @var string|null
*/
private $revert = null;
public function getComment() {
if ( $this->comment === null ) {
$this->comment = parent::getComment();
}
// Make sure we execute the LogLine hook so that we immediately return
// the correct value.
if ( $this->revert === null ) {
$this->getActionLinks();
}
return $this->comment;
}
/**
* @return string
* @return-taint onlysafefor_html
*/
protected function getActionMessage() {
$entry = $this->entry;
$action = LogPage::actionText(
$entry->getType(),
$entry->getSubtype(),
$entry->getTarget(),
$this->plaintext ? null : $this->context->getSkin(),
(array)$entry->getParameters(),
!$this->plaintext // whether to filter [[]] links
);
$performer = $this->getPerformerElement();
if ( !$this->irctext ) {
$sep = $this->msg( 'word-separator' );
$sep = $this->plaintext ? $sep->text() : $sep->escaped();
$action = $performer . $sep . $action;
}
return $action;
}
public function getActionLinks() {
if ( $this->revert !== null ) {
return $this->revert;
}
if ( $this->entry->isDeleted( LogPage::DELETED_ACTION ) ) {
$this->revert = '';
return $this->revert;
}
$title = $this->entry->getTarget();
$type = $this->entry->getType();
$subtype = $this->entry->getSubtype();
// Do nothing. The implementation is handled by the hook modifiying the
// passed-by-ref parameters. This also changes the default value so that
// getComment() and getActionLinks() do not call them indefinitely.
$this->revert = '';
// This is to populate the $comment member of this instance so that it
// can be modified when calling the hook just below.
if ( $this->comment === null ) {
$this->getComment();
}
$params = $this->entry->getParameters();
Hooks::runner()->onLogLine( $type, $subtype, $title, $params, $this->comment,
$this->revert, $this->entry->getTimestamp() );
return $this->revert;
}
}