11f729301b
I consider it busywork to maintain this, for no tangible benefit. Limiting the credited coverage to a class is limiting enough to exclude unintended coverage from reports. Especially as this helps ensure tracking coverage correctly for implementation details such as helper methods and internal methods that do not warrant their own test as that would defeat the purpose of tests exercising the contract and demonstrating good usage. Change-Id: Icf865f15cbd86585bbc02fc4943a960efb40c0eb
78 lines
2.1 KiB
PHP
78 lines
2.1 KiB
PHP
<?php
|
|
|
|
namespace MediaWiki\Tests\ResourceLoader;
|
|
|
|
use MediaWiki\ResourceLoader\LessVarFileModule;
|
|
use ReflectionMethod;
|
|
use ResourceLoaderTestCase;
|
|
|
|
/**
|
|
* @group ResourceLoader
|
|
* @covers \MediaWiki\ResourceLoader\LessVarFileModule
|
|
*/
|
|
class LessVarFileModuleTest extends ResourceLoaderTestCase {
|
|
|
|
public static function providerWrapAndEscapeMessage() {
|
|
return [
|
|
[
|
|
"Foo", '"Foo"',
|
|
],
|
|
[
|
|
"Foo bananas", '"Foo bananas"',
|
|
],
|
|
[
|
|
"Who's that test? Who's that test? It's Jess!",
|
|
'"Who\\\'s that test? Who\\\'s that test? It\\\'s Jess!"',
|
|
],
|
|
[
|
|
'Hello "he" said',
|
|
'"Hello \"he\" said"',
|
|
],
|
|
[
|
|
'boo";-o-link:javascript:alert(1);color:red;content:"',
|
|
'"boo\";-o-link:javascript:alert(1);color:red;content:\""',
|
|
],
|
|
[
|
|
'"jon\'s"',
|
|
'"\"jon\\\'s\""'
|
|
]
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider providerWrapAndEscapeMessage
|
|
*/
|
|
public function testEscapeMessage( $msg, $expected ) {
|
|
$method = new ReflectionMethod( LessVarFileModule::class, 'wrapAndEscapeMessage' );
|
|
$method->setAccessible( true );
|
|
$this->assertEquals( $expected, $method->invoke( null, $msg ) );
|
|
}
|
|
|
|
public function testLessMessagesFound() {
|
|
$context = $this->getResourceLoaderContext( 'qqx' );
|
|
$basePath = __DIR__ . '/../../data/less';
|
|
$module = new LessVarFileModule( [
|
|
'localBasePath' => $basePath,
|
|
'styles' => [ 'less-messages.less' ],
|
|
'lessMessages' => [ 'pieday' ],
|
|
] );
|
|
$module->setMessageBlob( '{"pieday":"March 14"}', 'qqx' );
|
|
|
|
$styles = $module->getStyles( $context );
|
|
$this->assertStringEqualsFile( $basePath . '/less-messages-exist.css', $styles['all'] );
|
|
}
|
|
|
|
public function testLessMessagesFailGraceful() {
|
|
$context = $this->getResourceLoaderContext( 'qqx' );
|
|
$basePath = __DIR__ . '/../../data/less';
|
|
$module = new LessVarFileModule( [
|
|
'localBasePath' => $basePath,
|
|
'styles' => [ 'less-messages.less' ],
|
|
'lessMessages' => [ 'pieday' ],
|
|
] );
|
|
$module->setMessageBlob( '{"something":"Else"}', 'qqx' );
|
|
|
|
$styles = $module->getStyles( $context );
|
|
$this->assertStringEqualsFile( $basePath . '/less-messages-nonexist.css', $styles['all'] );
|
|
}
|
|
}
|