wiki.techinc.nl/tests/phpunit/includes/language/LanguageConverterTest.php
Tim Starling 580ec48e5b Fix more PHPStorm inspections (#2)
* Illegal string offset and invalid argument supplied to foreach, due to incorrect type information
* Array internal pointer reset is unnecessary
* $hookData unused since MW 1.35 due to incomplete revert
* array_push() with single element
* Unnecessary sprintf()
* for loop can be replaced with str_repeat()
* preg_replace() can be replaced with rtrim()
* array_values() call is redundant
* Unnecessary cast to string
* Unnecessary ternary. Often the result relies on short-circuit evaluation, but I find it more readable nonetheless.

Change-Id: I4c45bdb59b51b243fa96286bec8b58deb097d707
2023-03-25 00:19:58 +00:00

248 lines
7.5 KiB
PHP

<?php
use MediaWiki\Linker\LinkTarget;
use MediaWiki\MainConfigNames;
use MediaWiki\Page\PageReference;
use MediaWiki\Page\PageReferenceValue;
use MediaWiki\Title\Title;
/**
* @group Language
*/
class LanguageConverterTest extends MediaWikiLangTestCase {
/** @var Language */
protected $lang;
/** @var DummyConverter */
protected $lc;
/**
* @param User $user
*/
private function setContextUser( User $user ) {
// LanguageConverter::getPreferredVariant() reads the user from
// RequestContext::getMain(), so set it occordingly
RequestContext::getMain()->setUser( $user );
}
protected function setUp(): void {
parent::setUp();
$this->overrideConfigValues( [
MainConfigNames::LanguageCode => 'en',
MainConfigNames::DefaultLanguageVariant => false,
] );
$this->setContentLang( 'tg' );
$this->setContextUser( new User );
$this->lang = $this->createNoOpMock( Language::class, [ 'factory', 'getNsText', 'ucfirst' ] );
$this->lang->method( 'getNsText' )->with( NS_MEDIAWIKI )->willReturn( 'MediaWiki' );
$this->lang->method( 'ucfirst' )->willReturnCallback( 'ucfirst' );
$this->lc = new DummyConverter( $this->lang );
}
protected function tearDown(): void {
unset( $this->lc );
unset( $this->lang );
parent::tearDown();
}
/**
* @covers LanguageConverter::getPreferredVariant
*/
public function testGetPreferredVariantDefaults() {
$this->assertEquals( 'tg', $this->lc->getPreferredVariant() );
}
/**
* @dataProvider provideGetPreferredVariant
* @covers LanguageConverter::getPreferredVariant
* @covers LanguageConverter::getURLVariant
*/
public function testGetPreferredVariant( $requestVal, $expected ) {
global $wgRequest;
$wgRequest->setVal( 'variant', $requestVal );
$this->assertEquals( $expected, $this->lc->getPreferredVariant() );
}
public static function provideGetPreferredVariant() {
yield 'normal (tg-latn)' => [ 'tg-latn', 'tg-latn' ];
yield 'deprecated (bat-smg)' => [ 'bat-smg', 'sgs' ];
yield 'BCP47 (en-simple)' => [ 'en-simple', 'simple' ];
}
/**
* @dataProvider provideGetPreferredVariantHeaders
* @covers LanguageConverter::getPreferredVariant
* @covers LanguageConverter::getHeaderVariant
*/
public function testGetPreferredVariantHeaders( $headerVal, $expected ) {
global $wgRequest;
$wgRequest->setHeader( 'Accept-Language', $headerVal );
$this->assertEquals( $expected, $this->lc->getPreferredVariant() );
}
public static function provideGetPreferredVariantHeaders() {
yield 'normal (tg-latn)' => [ 'tg-latn', 'tg-latn' ];
yield 'BCP47 (en-simple)' => [ 'en-simple', 'simple' ];
yield 'with weight #1' => [ 'tg;q=1', 'tg' ];
yield 'with weight #2' => [ 'tg-latn;q=1', 'tg-latn' ];
yield 'with multi' => [ 'en, tg-latn;q=1', 'tg-latn' ];
}
/**
* @dataProvider provideGetPreferredVariantUserOption
* @covers LanguageConverter::getPreferredVariant
*/
public function testGetPreferredVariantUserOption( $optionVal, $expected, $foreignLang ) {
$optionName = 'variant';
if ( $foreignLang ) {
$this->setContentLang( 'en' );
$optionName = 'variant-tg';
}
$userOptionsManager = $this->getServiceContainer()->getUserOptionsManager();
$user = new User;
$user->load(); // from 'defaults'
$user->mId = 1;
$user->mDataLoaded = true;
$userOptionsManager->setOption( $user, $optionName, $optionVal );
$this->setContextUser( $user );
$this->assertEquals( $expected, $this->lc->getPreferredVariant() );
}
public static function provideGetPreferredVariantUserOption() {
yield 'normal (tg-latn)' => [ 'tg-latn', 'tg-latn', false ];
yield 'deprecated (bat-smg)' => [ 'bat-smg', 'sgs', false ];
yield 'BCP47 (en-simple)' => [ 'en-simple', 'simple', false ];
yield 'for foreign language, normal (tg-latn)' => [ 'tg-latn', 'tg-latn', true ];
yield 'for foreign language, deprecated (bat-smg)' => [ 'bat-smg', 'sgs', true ];
yield 'for foreign language, BCP47 (en-simple)' => [ 'en-simple', 'simple', true ];
}
/**
* @covers LanguageConverter::getPreferredVariant
* @covers LanguageConverter::getUserVariant
* @covers LanguageConverter::getURLVariant
*/
public function testGetPreferredVariantHeaderUserVsUrl() {
global $wgRequest;
$this->setContentLang( 'tg-latn' );
$wgRequest->setVal( 'variant', 'tg' );
$userOptionsManager = $this->getServiceContainer()->getUserOptionsManager();
$user = User::newFromId( "admin" );
$user->setId( 1 );
$user->mFrom = 'defaults';
// The user's data is ignored because the variant is set in the URL.
$userOptionsManager->setOption( $user, 'variant', 'tg-latn' );
$this->setContextUser( $user );
$this->assertEquals( 'tg', $this->lc->getPreferredVariant() );
}
/**
* @dataProvider provideGetPreferredVariantDefaultLanguageVariant
* @covers LanguageConverter::getPreferredVariant
*/
public function testGetPreferredVariantDefaultLanguageVariant( $globalVal, $expected ) {
$this->overrideConfigValue( MainConfigNames::DefaultLanguageVariant, $globalVal );
$this->assertEquals( $expected, $this->lc->getPreferredVariant() );
}
public static function provideGetPreferredVariantDefaultLanguageVariant() {
yield 'normal (tg-latn)' => [ 'tg-latn', 'tg-latn' ];
yield 'deprecated (bat-smg)' => [ 'bat-smg', 'sgs' ];
yield 'BCP47 (en-simple)' => [ 'en-simple', 'simple' ];
}
/**
* @covers LanguageConverter::getPreferredVariant
* @covers LanguageConverter::getURLVariant
*/
public function testGetPreferredVariantDefaultLanguageVsUrlVariant() {
global $wgDefaultLanguageVariant, $wgRequest;
$this->setContentLang( 'tg-latn' );
$wgDefaultLanguageVariant = 'tg';
$wgRequest->setVal( 'variant', null );
$this->assertEquals( 'tg', $this->lc->getPreferredVariant() );
}
/**
* Test exhausting pcre.backtrack_limit
*
* @covers LanguageConverter::autoConvert
*/
public function testAutoConvertT124404() {
$testString = str_repeat( 'xxx xxx xxx', 1000 );
$testString .= "\n<big id='в'></big>";
$this->setIniSetting( 'pcre.backtrack_limit', 200 );
$result = $this->lc->autoConvert( $testString, 'tg-latn' );
// The в in the id attribute should not get converted to a v
$this->assertStringNotContainsString(
'v',
$result,
"в converted to v despite being in attribue"
);
}
/**
* @dataProvider provideTitlesToConvert
* @covers LanguageConverter::convertTitle
*
* @param LinkTarget|PageReference|callable $title title to convert
* @param string $expected
*/
public function testConvertTitle( $title, string $expected ): void {
if ( is_callable( $title ) ) {
$title = $title();
}
$actual = $this->lc->convertTitle( $title );
$this->assertSame( $expected, $actual );
}
public static function provideTitlesToConvert(): array {
return [
'Title FromText default' => [
Title::makeTitle( NS_MAIN, 'Dummy_title' ),
'Dummy title',
],
'Title FromText with NS' => [
Title::makeTitle( NS_FILE, 'Dummy_title' ),
'Акс:Dummy title',
],
'Title MainPage default' => [
static function () {
// Don't call this until services have been set up
return Title::newMainPage();
},
'Саҳифаи аслӣ',
],
'Title MainPage with MessageLocalizer' => [
static function () {
// Don't call this until services have been set up
return Title::newMainPage( new MockMessageLocalizer() );
},
'Саҳифаи аслӣ',
],
'TitleValue' => [
new TitleValue( NS_FILE, 'Dummy page' ),
'Акс:Dummy page',
],
'PageReference' => [
new PageReferenceValue( NS_FILE, 'Dummy page', PageReference::LOCAL ),
'Акс:Dummy page',
],
];
}
}