5e30a927bc
Just methods where adding "static" to the declaration was enough, I didn't do anything with providers that used $this. Initially by search and replace. There were many mistakes which I found mostly by running the PHPStorm inspection which searches for $this usage in a static method. Later I used the PHPStorm "make static" action which avoids the more obvious mistakes. Bug: T332865 Change-Id: I47ed6692945607dfa5c139d42edbd934fa4f3a36
122 lines
3.9 KiB
PHP
122 lines
3.9 KiB
PHP
<?php
|
|
|
|
use MediaWiki\Preferences\SignatureValidator;
|
|
use Wikimedia\TestingAccessWrapper;
|
|
|
|
/**
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
*/
|
|
|
|
/**
|
|
* @group Preferences
|
|
*/
|
|
class SignatureValidatorTest extends MediaWikiIntegrationTestCase {
|
|
|
|
private $validator;
|
|
|
|
protected function setUp(): void {
|
|
parent::setUp();
|
|
$this->validator = $this->getSignatureValidator();
|
|
}
|
|
|
|
/**
|
|
* Get a basic SignatureValidator for testing with.
|
|
* @return SignatureValidator
|
|
*/
|
|
protected function getSignatureValidator() {
|
|
$services = $this->getServiceContainer();
|
|
$lang = $services->getLanguageFactory()->getLanguage( 'en' );
|
|
$user = $services->getUserFactory()->newFromName( 'SignatureValidatorTest' );
|
|
$validator = $services->getSignatureValidatorFactory()->newSignatureValidator(
|
|
$user,
|
|
null,
|
|
ParserOptions::newFromUserAndLang( $user, $lang )
|
|
);
|
|
|
|
return TestingAccessWrapper::newFromObject( $validator );
|
|
}
|
|
|
|
/**
|
|
* @covers MediaWiki\Preferences\SignatureValidator::applyPreSaveTransform()
|
|
* @dataProvider provideApplyPreSaveTransform
|
|
*/
|
|
public function testApplyPreSaveTransform( $signature, $expected ) {
|
|
$pstSig = $this->validator->applyPreSaveTransform( $signature );
|
|
$this->assertSame( $expected, $pstSig );
|
|
}
|
|
|
|
public static function provideApplyPreSaveTransform() {
|
|
return [
|
|
'Pipe trick' =>
|
|
[ '[[test|]]', '[[test|test]]' ],
|
|
'One level substitution' =>
|
|
[ '{{subst:uc:whatever}}', 'WHATEVER' ],
|
|
'Hidden nested substitution' =>
|
|
[ '{{subst:uc:{}}{{subst:uc:{subst:uc:}}}{{subst:uc:}}}', false ],
|
|
'Hidden nested signature' =>
|
|
[ '{{subst:uc:~~}}{{subst:uc:~~}}', false ],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @covers MediaWiki\Preferences\SignatureValidator::checkUserLinks()
|
|
* @dataProvider provideCheckUserLinks
|
|
*/
|
|
public function testCheckUserLinks( $signature, $expected ) {
|
|
$isValid = $this->validator->checkUserLinks( $signature );
|
|
$this->assertSame( $expected, $isValid );
|
|
}
|
|
|
|
public static function provideCheckUserLinks() {
|
|
return [
|
|
'Perfect' =>
|
|
[ '[[User:SignatureValidatorTest|Signature]] ([[User talk:SignatureValidatorTest|talk]])', true ],
|
|
'User link' =>
|
|
[ '[[User:SignatureValidatorTest|Signature]]', true ],
|
|
'User talk link' =>
|
|
[ '[[User talk:SignatureValidatorTest]]', true ],
|
|
'Contributions link' =>
|
|
[ '[[Special:Contributions/SignatureValidatorTest]]', true ],
|
|
'Silly formatting permitted' =>
|
|
[ '[[_uSeR :_signatureValidatorTest_]]', true ],
|
|
'Contributions of wrong user' =>
|
|
[ '[[Special:Contributions/SignatureValidatorTestNot]]', false ],
|
|
'Link to subpage only' =>
|
|
[ '[[User:SignatureValidatorTest/blah|Signature]]', false ],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @covers MediaWiki\Preferences\SignatureValidator::checkLineBreaks()
|
|
* @dataProvider provideCheckLineBreaks
|
|
*/
|
|
public function testCheckLineBreaks( $signature, $expected ) {
|
|
$isValid = $this->validator->checkLineBreaks( $signature );
|
|
$this->assertSame( $expected, $isValid );
|
|
}
|
|
|
|
public static function provideCheckLineBreaks() {
|
|
return [
|
|
'Perfect' =>
|
|
[ '[[User:SignatureValidatorTest|Signature]] ([[User talk:SignatureValidatorTest|talk]])', true ],
|
|
'Line break' =>
|
|
[ "[[User:SignatureValidatorTest|Signature]] ([[User talk:SignatureValidatorTest|talk\n]])", false ],
|
|
];
|
|
}
|
|
|
|
}
|