wiki.techinc.nl/tests/phpunit/structure/ExtensionJsonValidationTest.php
Daimona Eaytoy 1c60cafab4 Add @coversNothing to all structure tests
With PHPUnit 9, tests without @covers tags are considered risky and emit
warnings. Not having @covers is bad practice anyway, so use
@coversNothing instead to make the intention clear, and re-enable the
phpcs rule.

Also rewrite an assertion in ResourcesTest that was bothering me.

Bug: T243600
Change-Id: I6dd683f93b6b2faed5f107be2ca7860602277fbc
2022-10-07 03:21:54 +02:00

67 lines
1.9 KiB
PHP

<?php
/**
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*/
/**
* Validates all loaded extensions and skins using the ExtensionRegistry
* against the extension.json schema in the docs/ folder.
* @coversNothing
*/
class ExtensionJsonValidationTest extends PHPUnit\Framework\TestCase {
use MediaWikiCoversValidator;
/**
* @var ExtensionJsonValidator
*/
protected $validator;
protected function setUp(): void {
parent::setUp();
$this->validator = new ExtensionJsonValidator( [ $this, 'markTestSkipped' ] );
$this->validator->checkDependencies();
if ( !ExtensionRegistry::getInstance()->getAllThings() ) {
$this->markTestSkipped(
'There are no extensions or skins loaded via the ExtensionRegistry'
);
}
}
public static function providePassesValidation() {
$allThings = ExtensionRegistry::getInstance()->getAllThings();
foreach ( $allThings as $thing ) {
yield [ $thing['path'] ];
}
}
/**
* @dataProvider providePassesValidation
* @param string $path Path to thing's json file
*/
public function testPassesValidation( $path ) {
try {
$this->validator->validate( $path );
// All good
$this->assertTrue( true );
} catch ( ExtensionJsonValidationError $e ) {
$this->fail( $e->getMessage() );
}
}
}