6ba47296d9
There is no way to express that Title::castFromPageIdentity(), Title::castFromPageReference() and Title::castFromLinkTarget() can only return null when the parameter is null. We need to add Phan suppressions or explicit types almost everywhere that these methods are used with parameters that are known to not be null. Instead, introduce new methods Title::newFromPageIdentity() and Title::newFromPageReference() (Title::newFromLinkTarget() already exists), without the null-coalescing behavior, and use them when the parameter is not null. This lets static analysis tools, and humans, easily understand where nulls can't appear. Do the same with the corresponding TitleFactory methods. Change the obvious uses of castFrom*() to newFrom*() (if there is a Phan suppression, a type check, or a method call on the result). Change-Id: Ida4da75953cf3bca372a40dc88022443109ca0cb
83 lines
2.5 KiB
PHP
83 lines
2.5 KiB
PHP
<?php
|
|
|
|
use MediaWiki\Title\Title;
|
|
use MediaWiki\Title\TitleFactory;
|
|
use PHPUnit\Framework\MockObject\MockObject;
|
|
|
|
/**
|
|
* @group Cache
|
|
* @covers HtmlCacheUpdater
|
|
*/
|
|
class HtmlCacheUpdaterTest extends MediaWikiUnitTestCase {
|
|
|
|
public function testGetCdnUrls() {
|
|
$htmlCache = new HtmlCacheUpdater(
|
|
$this->createHookContainer(),
|
|
$this->createTitleFactory(),
|
|
0, false, 86400 );
|
|
$title = $this->createMock( Title::class );
|
|
$title->method( 'canExist' )->willReturn( true );
|
|
$title->method( 'getInternalURL' )->willReturnCallback( static function ( $query = '' ) {
|
|
return 'https://test/?title=Example' . ( $query !== '' ? "&$query" : '' );
|
|
} );
|
|
|
|
$this->assertEquals(
|
|
[
|
|
'https://test/?title=Example',
|
|
'https://test/?title=Example&action=history',
|
|
],
|
|
$htmlCache->getUrls( $title ),
|
|
'all urls for an article'
|
|
);
|
|
$this->assertEquals(
|
|
[
|
|
'https://test/?title=Example',
|
|
],
|
|
$htmlCache->getUrls( $title, $htmlCache::PURGE_URLS_LINKSUPDATE_ONLY ),
|
|
'linkupdate urls for an article'
|
|
);
|
|
|
|
$title = $this->createMock( Title::class );
|
|
$title->method( 'canExist' )->willReturn( true );
|
|
$title->method( 'getInternalURL' )->willReturnCallback( static function ( $query = '' ) {
|
|
return 'https://test/?title=User:Example/foo.js' . ( $query !== '' ? "&$query" : '' );
|
|
} );
|
|
$title->method( 'isUserJsConfigPage' )->willReturn( true );
|
|
$this->assertEquals(
|
|
[
|
|
'https://test/?title=User:Example/foo.js',
|
|
'https://test/?title=User:Example/foo.js&action=history',
|
|
'https://test/?title=User:Example/foo.js&action=raw&ctype=text/javascript',
|
|
],
|
|
$htmlCache->getUrls( $title ),
|
|
'all urls for a user js page'
|
|
);
|
|
|
|
$title = $this->createMock( Title::class );
|
|
$title->method( 'canExist' )->willReturn( true );
|
|
$title->method( 'getInternalURL' )->willReturnCallback( static function ( $query = '' ) {
|
|
return 'https://test/?title=MediaWiki:Example.js' . ( $query !== '' ? "&$query" : '' );
|
|
} );
|
|
$title->method( 'isSiteJsConfigPage' )->willReturn( true );
|
|
$this->assertEquals(
|
|
[
|
|
'https://test/?title=MediaWiki:Example.js',
|
|
'https://test/?title=MediaWiki:Example.js&action=history',
|
|
'https://test/?title=MediaWiki:Example.js&action=raw&ctype=text/javascript',
|
|
],
|
|
$htmlCache->getUrls( $title ),
|
|
'all urls for a site js page'
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @return MockObject|TitleFactory
|
|
*/
|
|
private function createTitleFactory() {
|
|
$factory = $this->createNoOpMock( TitleFactory::class, [ 'newFromPageReference' ] );
|
|
|
|
$factory->method( 'newFromPageReference' )->willReturnArgument( 0 );
|
|
|
|
return $factory;
|
|
}
|
|
}
|