8f778a8b23
In preparation for the underlying library changing, generalize the tests for this code so that test changes are kept to a minimum in the actual commit. Rather than test the upstream directly, move our custom test cases from JsMinPlusTest to ResourceLoader/ModuleTest. Fix benchmarkJSMinPlus.php to not emit warnings on PHP 8.2 due to use of dynamic property creation: > PHP Deprecated: Creation of dynamic property JSNode::$readOnly > is deprecated in /mediawiki/includes/libs/jsminplus.php:1728 Bug: T75714 Change-Id: I0515be8229f51de48c1f0c92f09e2d827e1b1add
75 lines
2.1 KiB
PHP
75 lines
2.1 KiB
PHP
<?php
|
|
/**
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
* @ingroup Maintenance
|
|
*/
|
|
|
|
require_once __DIR__ . '/Maintenance.php';
|
|
|
|
/**
|
|
* Ad-hoc run ResourceLoader validation for user-supplied JavaScript.
|
|
*
|
|
* Matches the behaviour of ResourceLoader\Module::validateScriptFile, currently
|
|
* powered by the the JSMinPlus library.
|
|
*
|
|
* @ingroup Maintenance
|
|
*/
|
|
class JSParseHelper extends Maintenance {
|
|
public $errs = 0;
|
|
|
|
public function __construct() {
|
|
parent::__construct();
|
|
$this->addDescription( 'Validate syntax of JavaScript files' );
|
|
$this->addArg( 'file(s)', 'JavaScript files or "-" to read stdin', true );
|
|
}
|
|
|
|
public function execute() {
|
|
$files = $this->getArgs();
|
|
|
|
$parser = new JSParser();
|
|
foreach ( $files as $filename ) {
|
|
$js = $filename === '-'
|
|
? stream_get_contents( STDIN )
|
|
// phpcs:ignore Generic.PHP.NoSilencedErrors
|
|
: @file_get_contents( $filename );
|
|
if ( $js === false ) {
|
|
$this->output( "$filename ERROR: could not read file\n" );
|
|
$this->errs++;
|
|
continue;
|
|
}
|
|
|
|
try {
|
|
// phpcs:ignore Generic.PHP.NoSilencedErrors
|
|
@$parser->parse( $js, $filename, 1 );
|
|
} catch ( Exception $e ) {
|
|
$this->errs++;
|
|
$this->output( "$filename ERROR: " . $e->getMessage() . "\n" );
|
|
continue;
|
|
}
|
|
|
|
$this->output( "$filename OK\n" );
|
|
}
|
|
|
|
if ( $this->errs > 0 ) {
|
|
$this->fatalError( 'Failed.' );
|
|
}
|
|
}
|
|
}
|
|
|
|
$maintClass = JSParseHelper::class;
|
|
require_once RUN_MAINTENANCE_IF_MAIN;
|