wiki.techinc.nl/includes/ProxyTools.php
Bryan Davis 354be95608 Skip IP::isInRange() test if input is not in CIDR notation
IP:isInRange() performs several moderately expensive tests via regular
expression matching that can cause unwanted load with a sufficiently
complicated runtime configuration. Check the $wgSquidServersNoPurge
value to see if it includes the CIDR mask separator token ('/') before
continuing on to perform those more expensive tests.

Follows up Ia81bed7d8b42a2d2b200a3ce45a74e3784cdca2a

Bug: 52829

Change-Id: Ia557cb54f3a1bf67c8282140ab748369faa83028
2013-11-13 20:44:34 +00:00

100 lines
2.8 KiB
PHP

<?php
/**
* Functions for dealing with proxies.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*
* @file
*/
/**
* Extracts the XFF string from the request header
* Note: headers are spoofable
*
* @deprecated in 1.19; use $wgRequest->getHeader( 'X-Forwarded-For' ) instead.
* @return string
*/
function wfGetForwardedFor() {
wfDeprecated( __METHOD__, '1.19' );
global $wgRequest;
return $wgRequest->getHeader( 'X-Forwarded-For' );
}
/**
* Returns the browser/OS data from the request header
* Note: headers are spoofable
*
* @deprecated in 1.18; use $wgRequest->getHeader( 'User-Agent' ) instead.
* @return string
*/
function wfGetAgent() {
wfDeprecated( __METHOD__, '1.18' );
global $wgRequest;
return $wgRequest->getHeader( 'User-Agent' );
}
/**
* Work out the IP address based on various globals
* For trusted proxies, use the XFF client IP (first of the chain)
*
* @deprecated in 1.19; call $wgRequest->getIP() directly.
* @return string
*/
function wfGetIP() {
wfDeprecated( __METHOD__, '1.19' );
global $wgRequest;
return $wgRequest->getIP();
}
/**
* Checks if an IP is a trusted proxy provider.
* Useful to tell if X-Forwarded-For data is possibly bogus.
* Squid cache servers for the site are whitelisted.
*
* @param $ip String
* @return bool
*/
function wfIsTrustedProxy( $ip ) {
$trusted = wfIsConfiguredProxy( $ip );
wfRunHooks( 'IsTrustedProxy', array( &$ip, &$trusted ) );
return $trusted;
}
/**
* Checks if an IP matches a proxy we've configured.
* @param $ip String
* @return bool
* @since 1.23 Supports CIDR ranges in $wgSquidServersNoPurge
*/
function wfIsConfiguredProxy( $ip ) {
global $wgSquidServers, $wgSquidServersNoPurge;
// quick check of known proxy servers
$trusted = in_array( $ip, $wgSquidServers )
|| in_array( $ip, $wgSquidServersNoPurge );
if ( !$trusted ) {
// slightly slower check to see if the ip is listed directly or in a CIDR
// block in $wgSquidServersNoPurge
foreach ( $wgSquidServersNoPurge as $block ) {
if ( strpos( $block, '/' ) !== false && IP::isInRange( $ip, $block ) ) {
$trusted = true;
break;
}
}
}
return $trusted;
}