65e4646444
This is motivated by I1568d44, a 5 (!) year old patch. This patch does: * Change the visibility from protected to private. I checked. There are no subclasses. No need to make this method available. * Remove unused function parameters. * Turn some conditions into guard clauses. * Turn all these hard to read "if: big chunk of code, else: 1-liner" around to have the 1-liner first, or just get rid of the not needed else. * Avoid reusing the same variable name for different things. This is really confusing. * Inline trivial stuff. * Improve some "@return string" documentation to say what the string is. * Reduce the amount of duplicate code. Change-Id: Ied90f020057d9bdf4d979f380c3aedad5eb3ad5f |
||
|---|---|---|
| .. | ||
| BlockLogFormatter.php | ||
| ContentModelLogFormatter.php | ||
| DatabaseLogEntry.php | ||
| DeleteLogFormatter.php | ||
| ImportLogFormatter.php | ||
| LegacyLogFormatter.php | ||
| LogEntry.php | ||
| LogEntryBase.php | ||
| LogEventsList.php | ||
| LogFormatter.php | ||
| LogPage.php | ||
| LogPager.php | ||
| ManualLogEntry.php | ||
| MergeLogFormatter.php | ||
| MoveLogFormatter.php | ||
| NewUsersLogFormatter.php | ||
| PageLangLogFormatter.php | ||
| PatrolLog.php | ||
| PatrolLogFormatter.php | ||
| ProtectLogFormatter.php | ||
| RCDatabaseLogEntry.php | ||
| RightsLogFormatter.php | ||
| TagLogFormatter.php | ||
| UploadLogFormatter.php | ||
| WikitextLogFormatter.php | ||