9c57ea2b7f
This patch tries to make assertions in tests more readable by using more self-documenting assertions as provided by modern PHPUnit versions. Among a few others, these two main changes are done: * I found a lot of assertions with the expected value being the *second* parameter. I did not changed all of them. Only some that can be replaced with assertNull() and such. * I try to replace all `assertTrue( is_…() )` with dedicated assertions. Change-Id: I1fc72188fbd0edacf13886e7f9a9eacbd85f13c2
117 lines
2.4 KiB
PHP
117 lines
2.4 KiB
PHP
<?php
|
|
|
|
use MediaWiki\Shell\Shell;
|
|
|
|
/**
|
|
* Tests related to JPEG chroma subsampling via $wgJpegPixelFormat setting.
|
|
*
|
|
* @group Media
|
|
* @group medium
|
|
*/
|
|
class JpegPixelFormatTest extends MediaWikiMediaTestCase {
|
|
|
|
protected function setUp() : void {
|
|
parent::setUp();
|
|
}
|
|
|
|
/**
|
|
* Mark this test as creating thumbnail files.
|
|
*/
|
|
protected function createsThumbnails() {
|
|
return true;
|
|
}
|
|
|
|
/**
|
|
*
|
|
* @dataProvider providePixelFormats
|
|
* @covers BitmapHandler::imageMagickSubsampling
|
|
*/
|
|
public function testPixelFormatRendering( $sourceFile, $pixelFormat, $samplingFactor ) {
|
|
global $wgUseImageMagick, $wgUseImageResize;
|
|
if ( !$wgUseImageMagick ) {
|
|
$this->markTestSkipped( "This test is only applicable when using ImageMagick thumbnailing" );
|
|
}
|
|
if ( !$wgUseImageResize ) {
|
|
$this->markTestSkipped( "This test is only applicable when using thumbnailing" );
|
|
}
|
|
|
|
$fmtStr = var_export( $pixelFormat, true );
|
|
$this->setMwGlobals( 'wgJpegPixelFormat', $pixelFormat );
|
|
|
|
$file = $this->dataFile( $sourceFile, 'image/jpeg' );
|
|
|
|
$params = [
|
|
'width' => 320,
|
|
];
|
|
$thumb = $file->transform( $params, File::RENDER_NOW | File::RENDER_FORCE );
|
|
$this->assertTrue( !$thumb->isError(), "created JPEG thumbnail for pixel format $fmtStr" );
|
|
|
|
$path = $thumb->getLocalCopyPath();
|
|
$this->assertIsString( $path, "path returned for JPEG thumbnail for $fmtStr" );
|
|
|
|
$result = Shell::command( 'identify',
|
|
'-format',
|
|
'%[jpeg:sampling-factor]',
|
|
$path
|
|
)->execute();
|
|
$this->assertSame( 0,
|
|
$result->getExitCode(),
|
|
"ImageMagick's identify command should return success"
|
|
);
|
|
|
|
$expected = $samplingFactor;
|
|
$actual = trim( $result->getStdout() );
|
|
$this->assertEquals(
|
|
$expected,
|
|
$actual,
|
|
"IM identify expects JPEG chroma subsampling \"$expected\" for $fmtStr"
|
|
);
|
|
}
|
|
|
|
public static function providePixelFormats() {
|
|
return [
|
|
// From 4:4:4 source file
|
|
[
|
|
'yuv444.jpg',
|
|
false,
|
|
'1x1,1x1,1x1'
|
|
],
|
|
[
|
|
'yuv444.jpg',
|
|
'yuv444',
|
|
'1x1,1x1,1x1'
|
|
],
|
|
[
|
|
'yuv444.jpg',
|
|
'yuv422',
|
|
'2x1,1x1,1x1'
|
|
],
|
|
[
|
|
'yuv444.jpg',
|
|
'yuv420',
|
|
'2x2,1x1,1x1'
|
|
],
|
|
// From 4:2:0 source file
|
|
[
|
|
'yuv420.jpg',
|
|
false,
|
|
'2x2,1x1,1x1'
|
|
],
|
|
[
|
|
'yuv420.jpg',
|
|
'yuv444',
|
|
'1x1,1x1,1x1'
|
|
],
|
|
[
|
|
'yuv420.jpg',
|
|
'yuv422',
|
|
'2x1,1x1,1x1'
|
|
],
|
|
[
|
|
'yuv420.jpg',
|
|
'yuv420',
|
|
'2x2,1x1,1x1'
|
|
]
|
|
];
|
|
}
|
|
}
|