f95dc8faff
$subpage being null is clearly documented in SpecialPage::run,
SpecialPage::execute, and most special page subclasses.
But all the redirect subclasses only copied part of the typehint,
making it look like it's always a string.
For SpecialMyLanguage, follows-up b1853bba0. Don't cast null to
empty string, and don't bother giving Title::newFromText an empty
string only to bail out with null again.
Also:
* Add visibility 'public' where missing.
* Add or correct relevant documentation comments.
* In SpecialMyRedirectPages, handle error first and avoid having
final return inside a conditional; Remove redunant 'else'.
Change-Id: Ie3543f44011832b198bb3d3e32528b6a2868dee1
55 lines
1.5 KiB
PHP
55 lines
1.5 KiB
PHP
<?php
|
|
/**
|
|
* Implements Special:Filepath
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
* @ingroup SpecialPage
|
|
*/
|
|
|
|
/**
|
|
* A special page that redirects to the URL of a given file
|
|
*
|
|
* @ingroup SpecialPage
|
|
*/
|
|
class SpecialFilepath extends RedirectSpecialPage {
|
|
public function __construct() {
|
|
parent::__construct( 'Filepath' );
|
|
$this->mAllowedRedirectParams = array( 'width', 'height' );
|
|
}
|
|
|
|
/**
|
|
* Implement by redirecting through Special:Redirect/file.
|
|
*
|
|
* @param string|null $subpage
|
|
* @return Title
|
|
*/
|
|
public function getRedirect( $par ) {
|
|
$file = $par ?: $this->getRequest()->getText( 'file' );
|
|
|
|
if ( $file ) {
|
|
$argument = "file/$file";
|
|
} else {
|
|
$argument = 'file';
|
|
}
|
|
return SpecialPage::getSafeTitleFor( 'Redirect', $argument );
|
|
}
|
|
|
|
protected function getGroupName() {
|
|
return 'media';
|
|
}
|
|
}
|