Various code passes null around to mean "an invalid password". It shouldn't all have to test for null and specially handle that. This also fixes a codepath where User::$mNewpassword could get set to an empty string rather than a password object, which would cause problems later when anything else tries to use it. Bug: 71421 Change-Id: Ib5f94b52c07e7dba89328b98fb43c86db95ee09f
39 lines
1.3 KiB
PHP
39 lines
1.3 KiB
PHP
<?php
|
|
/**
|
|
* Testing framework for the Password infrastructure
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
*/
|
|
|
|
class PasswordTest extends MediaWikiTestCase {
|
|
/**
|
|
* @covers InvalidPassword::equals
|
|
*/
|
|
public function testInvalidUnequalInvalid() {
|
|
$invalid1 = User::getPasswordFactory()->newFromCiphertext( null );
|
|
$invalid2 = User::getPasswordFactory()->newFromCiphertext( null );
|
|
|
|
$this->assertFalse( $invalid1->equals( $invalid2 ) );
|
|
}
|
|
|
|
public function testInvalidPlaintext() {
|
|
$invalid = User::getPasswordFactory()->newFromPlaintext( null );
|
|
|
|
$this->assertInstanceOf( 'InvalidPassword', $invalid );
|
|
}
|
|
}
|