fecb2320a8
Add a new ObjectFactory::constructClassInstance() method that uses a loop unrolling type of technique to avoid using ReflectionClass when creating new class instances with 10 or fewer constructor arguments. I really wanted to also include the use of PHP 5.6's `...` splat operator when supported but there is no way to conditionally use a new operator in a way that still allows older versions of PHP to parse the same source file. Bug: T115729 Change-Id: Ia29c4526f4bac51696654c9b0677cb3f70359966
122 lines
3.8 KiB
PHP
122 lines
3.8 KiB
PHP
<?php
|
|
/**
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
*/
|
|
|
|
class ObjectFactoryTest extends PHPUnit_Framework_TestCase {
|
|
|
|
/**
|
|
* @covers ObjectFactory::getObjectFromSpec
|
|
*/
|
|
public function testClosureExpansionDisabled() {
|
|
$obj = ObjectFactory::getObjectFromSpec( array(
|
|
'class' => 'ObjectFactoryTestFixture',
|
|
'args' => array( function() {
|
|
return 'unwrapped';
|
|
}, ),
|
|
'calls' => array(
|
|
'setter' => array( function() {
|
|
return 'unwrapped';
|
|
}, ),
|
|
),
|
|
'closure_expansion' => false,
|
|
) );
|
|
$this->assertInstanceOf( 'Closure', $obj->args[0] );
|
|
$this->assertSame( 'unwrapped', $obj->args[0]() );
|
|
$this->assertInstanceOf( 'Closure', $obj->setterArgs[0] );
|
|
$this->assertSame( 'unwrapped', $obj->setterArgs[0]() );
|
|
}
|
|
|
|
/**
|
|
* @covers ObjectFactory::getObjectFromSpec
|
|
*/
|
|
public function testClosureExpansionEnabled() {
|
|
$obj = ObjectFactory::getObjectFromSpec( array(
|
|
'class' => 'ObjectFactoryTestFixture',
|
|
'args' => array( function() {
|
|
return 'unwrapped';
|
|
}, ),
|
|
'calls' => array(
|
|
'setter' => array( function() {
|
|
return 'unwrapped';
|
|
}, ),
|
|
),
|
|
'closure_expansion' => true,
|
|
) );
|
|
$this->assertInternalType( 'string', $obj->args[0] );
|
|
$this->assertSame( 'unwrapped', $obj->args[0] );
|
|
$this->assertInternalType( 'string', $obj->setterArgs[0] );
|
|
$this->assertSame( 'unwrapped', $obj->setterArgs[0] );
|
|
|
|
$obj = ObjectFactory::getObjectFromSpec( array(
|
|
'class' => 'ObjectFactoryTestFixture',
|
|
'args' => array( function() {
|
|
return 'unwrapped';
|
|
}, ),
|
|
'calls' => array(
|
|
'setter' => array( function() {
|
|
return 'unwrapped';
|
|
}, ),
|
|
),
|
|
) );
|
|
$this->assertInternalType( 'string', $obj->args[0] );
|
|
$this->assertSame( 'unwrapped', $obj->args[0] );
|
|
$this->assertInternalType( 'string', $obj->setterArgs[0] );
|
|
$this->assertSame( 'unwrapped', $obj->setterArgs[0] );
|
|
}
|
|
|
|
/**
|
|
* @covers ObjectFactory::constructClassInstance
|
|
* @dataProvider provideConstructClassInstance
|
|
*/
|
|
public function testConstructClassInstance( $args ) {
|
|
$obj = ObjectFactory::constructClassInstance(
|
|
'ObjectFactoryTestFixture', $args
|
|
);
|
|
$this->assertSame( $args, $obj->args );
|
|
}
|
|
|
|
public function provideConstructClassInstance() {
|
|
// These args go to 11. I thought about making 10 one louder, but 11!
|
|
return array(
|
|
'0 args' => array( array() ),
|
|
'1 args' => array( array( 1, ) ),
|
|
'2 args' => array( array( 1, 2, ) ),
|
|
'3 args' => array( array( 1, 2, 3, ) ),
|
|
'4 args' => array( array( 1, 2, 3, 4, ) ),
|
|
'5 args' => array( array( 1, 2, 3, 4, 5, ) ),
|
|
'6 args' => array( array( 1, 2, 3, 4, 5, 6, ) ),
|
|
'7 args' => array( array( 1, 2, 3, 4, 5, 6, 7, ) ),
|
|
'8 args' => array( array( 1, 2, 3, 4, 5, 6, 7, 8, ) ),
|
|
'9 args' => array( array( 1, 2, 3, 4, 5, 6, 7, 8, 9, ) ),
|
|
'10 args' => array( array( 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, ) ),
|
|
'11 args' => array( array( 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, ) ),
|
|
);
|
|
}
|
|
}
|
|
|
|
class ObjectFactoryTestFixture {
|
|
public $args;
|
|
public $setterArgs;
|
|
public function __construct( /*...*/ ) {
|
|
$this->args = func_get_args();
|
|
}
|
|
public function setter( /*...*/ ) {
|
|
$this->setterArgs = func_get_args();
|
|
}
|
|
}
|