From 76c57ca78605b9ab8dd02f7e95bbee371e671ed5 Mon Sep 17 00:00:00 2001 From: Richard Milewski Date: Sun, 17 Mar 2024 13:26:39 -0700 Subject: [PATCH 1/4] Fix small omission --- tutorials/Rounding_the_Cube.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tutorials/Rounding_the_Cube.md b/tutorials/Rounding_the_Cube.md index 21063c9..ae115f7 100644 --- a/tutorials/Rounding_the_Cube.md +++ b/tutorials/Rounding_the_Cube.md @@ -226,7 +226,7 @@ include diff() prismoid([30,20], [40,30], rounding = 2, h = 20, $fn = 64) edge_profile(BOT, excess = 15) - mask2d_teardrop(h = 5, mask_angle = $edge_angle, $fn = 64); + mask2d_teardrop(h = 5, angle = 40, mask_angle = $edge_angle, $fn = 64); ``` ```openscad-3d; ImgOnly VPR=[85,0,5] @@ -234,7 +234,7 @@ include diff() prismoid([30,20], [40,30], rounding = 2, h = 20, $fn = 64) edge_profile(BOT, excess = 15) - mask2d_teardrop(h = 5, mask_angle = $edge_angle, $fn = 64); + mask2d_teardrop(h = 5, angle = 40, mask_angle = $edge_angle, $fn = 64); ``` In addition to the simple [roundover](https://github.com/BelfrySCAD/BOSL2/wiki/masks2d.scad#functionmodule-mask2d_roundover) mask, and the [teardrop](https://github.com/BelfrySCAD/BOSL2/wiki/masks2d.scad#functionmodule-mask2d_teardrop) mask, there are masks for [cove](https://github.com/BelfrySCAD/BOSL2/wiki/masks2d.scad#functionmodule-mask2d_cove), [chamfer](https://github.com/BelfrySCAD/BOSL2/wiki/masks2d.scad#functionmodule-mask2d_chamfer), [rabbet](https://github.com/BelfrySCAD/BOSL2/wiki/masks2d.scad#functionmodule-mask2d_rabbet), [dovetail](https://github.com/BelfrySCAD/BOSL2/wiki/masks2d.scad#functionmodule-mask2d_dovetail) and [ogee](https://github.com/BelfrySCAD/BOSL2/wiki/masks2d.scad#functionmodule-mask2d_ogee) edges. From fad3f92dfd9c53c543465bcf6547c1b6cca6fe1b Mon Sep 17 00:00:00 2001 From: Richard Milewski Date: Sun, 17 Mar 2024 14:06:34 -0700 Subject: [PATCH 2/4] Adjusted VPR on img 22 --- tutorials/Rounding_the_Cube.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tutorials/Rounding_the_Cube.md b/tutorials/Rounding_the_Cube.md index ae115f7..ef86550 100644 --- a/tutorials/Rounding_the_Cube.md +++ b/tutorials/Rounding_the_Cube.md @@ -229,7 +229,7 @@ diff() mask2d_teardrop(h = 5, angle = 40, mask_angle = $edge_angle, $fn = 64); ``` -```openscad-3d; ImgOnly VPR=[85,0,5] +```openscad-3d; ImgOnly VPR=[88.5,0,6.4] VPT=[0,16,10] VPD=110 include diff() prismoid([30,20], [40,30], rounding = 2, h = 20, $fn = 64) From 858682fd403c9fc09de873e018a6bf2138745371 Mon Sep 17 00:00:00 2001 From: Richard Milewski Date: Sun, 17 Mar 2024 14:11:31 -0700 Subject: [PATCH 3/4] Tweak teardrop angle --- tutorials/Rounding_the_Cube.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tutorials/Rounding_the_Cube.md b/tutorials/Rounding_the_Cube.md index ef86550..1532490 100644 --- a/tutorials/Rounding_the_Cube.md +++ b/tutorials/Rounding_the_Cube.md @@ -226,7 +226,7 @@ include diff() prismoid([30,20], [40,30], rounding = 2, h = 20, $fn = 64) edge_profile(BOT, excess = 15) - mask2d_teardrop(h = 5, angle = 40, mask_angle = $edge_angle, $fn = 64); + mask2d_teardrop(h = 5, angle = 50, mask_angle = $edge_angle, $fn = 64); ``` ```openscad-3d; ImgOnly VPR=[88.5,0,6.4] VPT=[0,16,10] VPD=110 @@ -234,7 +234,7 @@ include diff() prismoid([30,20], [40,30], rounding = 2, h = 20, $fn = 64) edge_profile(BOT, excess = 15) - mask2d_teardrop(h = 5, angle = 40, mask_angle = $edge_angle, $fn = 64); + mask2d_teardrop(h = 5, angle = 50, mask_angle = $edge_angle, $fn = 64); ``` In addition to the simple [roundover](https://github.com/BelfrySCAD/BOSL2/wiki/masks2d.scad#functionmodule-mask2d_roundover) mask, and the [teardrop](https://github.com/BelfrySCAD/BOSL2/wiki/masks2d.scad#functionmodule-mask2d_teardrop) mask, there are masks for [cove](https://github.com/BelfrySCAD/BOSL2/wiki/masks2d.scad#functionmodule-mask2d_cove), [chamfer](https://github.com/BelfrySCAD/BOSL2/wiki/masks2d.scad#functionmodule-mask2d_chamfer), [rabbet](https://github.com/BelfrySCAD/BOSL2/wiki/masks2d.scad#functionmodule-mask2d_rabbet), [dovetail](https://github.com/BelfrySCAD/BOSL2/wiki/masks2d.scad#functionmodule-mask2d_dovetail) and [ogee](https://github.com/BelfrySCAD/BOSL2/wiki/masks2d.scad#functionmodule-mask2d_ogee) edges. From 487021ab6c671e2ecb85e775211c119004cf76e4 Mon Sep 17 00:00:00 2001 From: Richard Milewski Date: Mon, 18 Mar 2024 14:36:04 -0700 Subject: [PATCH 4/4] Shortened Prismoid Examples ...and repositioned the viewport. --- masks2d.scad | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/masks2d.scad b/masks2d.scad index 798fa4e..287c969 100644 --- a/masks2d.scad +++ b/masks2d.scad @@ -102,30 +102,30 @@ function _inset_corner(corner, mask_angle, inset, excess, flat_top) = // xrot(90) // linear_extrude(height=30, center=true) // mask2d_roundover(r=10); -// Example(3D,Med): Rounding over top of an extreme prismoid using height option +// Example(3D,Med,VPT=[25,30,12],VPR=[68,0,12],VPD=180): Rounding over top of an extreme prismoid using height option // diff() -// prismoid([30,20], [50,60], h=50, shift=[40,50]) -// edge_profile(TOP, excess=20) +// prismoid([30,20], [50,60], h=20, shift=[40,50]) +// edge_profile(TOP, excess=27) // mask2d_roundover(height=5, mask_angle=$edge_angle, $fn=128); -// Example(3D,Med): Using the quarter_round option results in a lip on obtuse angles, so it may not be the best choice for pure roundings. +// Example(3D,Med,VPT=[25,30,12],VPR=[68,0,12],VPD=180): Using the quarter_round option results in a lip on obtuse angles, so it may not be the best choice for pure roundings. // diff() -// prismoid([30,20], [50,60], h=50, shift=[40,50]) -// edge_profile(TOP, excess=20) +// prismoid([30,20], [50,60], h=20, shift=[40,50]) +// edge_profile(TOP, excess=27) // mask2d_roundover(r=5, mask_angle=$edge_angle, quarter_round=true, $fn=128); -// Example(3D,Med): Can improve the quarter round option by using it only for acute angles and falling back on regular rounding for obtuse angles. Note that in this case, obtuse angles are fully rounded, but acute angles still have a corner, but one that is not as sharp as the original angle. +// // Example(3D,Med,VPT=[25,30,12],VPR=[68,0,12],VPD=180): Can improve the quarter round option by using it only for acute angles and falling back on regular rounding for obtuse angles. Note that in this case, obtuse angles are fully rounded, but acute angles still have a corner, but one that is not as sharp as the original angle. // diff() -// prismoid([30,20], [50,60], h=50, shift=[40,50]) -// edge_profile(TOP, excess=20) +// prismoid([30,20], [50,60], h=20, shift=[40,50]) +// edge_profile(TOP, excess=27) // mask2d_roundover(r=5, mask_angle=$edge_angle, quarter_round=$edge_angle<90, $fn=32); -// Example(3D,Med): Creating a bead on the prismoid using the height option with flat_top=true: +// Example(3D,Med,VPT=[25,30,12],VPR=[68,0,12],VPD=180): Creating a bead on the prismoid using the height option with flat_top=true: // diff() -// prismoid([30,20], [50,60], h=50, shift=[40,50]) -// edge_profile(TOP, excess=20) +// prismoid([30,20], [50,60], h=20, shift=[40,50]) +// edge_profile(TOP, excess=27) // mask2d_roundover(height=5, mask_angle=$edge_angle, inset=1.5, flat_top=true, $fn=128); -// Example(3D,Med): Bead may be more pleasing using the quarter_round option, with curves terminating in a plane parallel to the prismoid top. The size of the inset edge will be larger than requested when the angle is obtuse. +// Example(3D,Med,VPT=[25,30,12],VPR=[68,0,12],VPD=180): Bead may be more pleasing using the quarter_round option, with curves terminating in a plane parallel to the prismoid top. The size of the inset edge will be larger than requested when the angle is obtuse. // diff() -// prismoid([30,20], [50,60], h=50, shift=[40,50]) -// edge_profile(TOP, excess=20) +// prismoid([30,20], [50,60], h=20, shift=[40,50]) +// edge_profile(TOP, excess=27) // mask2d_roundover(r=5, mask_angle=$edge_angle, quarter_round=true, inset=1.5, $fn=128); module mask2d_roundover(r, inset=0, mask_angle=90, excess=0.01, flat_top, d, h, height, cut, quarter_round=false, joint, anchor=CENTER,spin=0) { path = mask2d_roundover(r=r, d=d, h=h, height=height, cut=cut, joint=joint, inset=inset,