grey/BOSL2
1
0
Fork 0
mirror of https://github.com/BelfrySCAD/BOSL2.git synced 2024-12-29 16:29:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix find_noncollinear_points

Browse source
This commit is contained in:
Adrian Mariano 2020-07-28 17:54:45 -04:00
parent 65125ed57a
commit 3c9e304675
1 changed files with 27 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
geometry.scad
View file

@ -1359,7 +1359,21 @@ function first_noncollinear(i1, i2, points) =
// find_noncollinear_points(points);
// Description:
// Finds the indices of three good non-collinear points from the points list `points`.
function find_noncollinear_points(points) =
function find_noncollinear_points(points,error=true,eps=EPSILON) =
let(
pa = points[0],
b = furthest_point(pa, points),
n = unit(points[b]-pa),
relpoints = [for(pt=points) pt-pa],
proj = relpoints * n,
distlist = [for(i=[0:len(points)-1]) norm(relpoints[i]-proj[i]*n)]
)
max(distlist)<eps
? assert(!error, "Cannot find three noncollinear points in pointlist.")
[]
: [0,b,max_index(distlist)];
function old_find_noncollinear_points(points,error=true) =
let(
a = 0,
b = furthest_point(points[a], points),
@ -1368,12 +1382,17 @@ function find_noncollinear_points(points) =
c = max_index([
for (p=points)
(approx(p,pa) || approx(p,pb))? 0 :
let(score =
sin(vector_angle(points[a]-p,points[b]-p)) *
norm(p-points[a]) * norm(p-points[b])
])
norm(p-points[a]) * norm(p-points[b]),fff=echo(score=score))
approx(score,0,eps=1e-7) ? -1 : score])
,foo=echo(pval = a,b,c)
)
assert(c!=a && c!=b, "Cannot find three noncollinear points in pointlist.")
[a, b, c];
c ==a || c==b
? assert(!error, "Cannot find three noncollinear points in pointlist.")
[]
: [a, b, c];
// Function: pointlist_bounds()