grey/BOSL2
1
0
Fork 0
mirror of https://github.com/BelfrySCAD/BOSL2.git synced 2025-01-04 03:09:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #1220 from BelfrySCAD/revarbat_dev

Browse source 
Fixed tooth profile pruning when undercut is not present.
This commit is contained in:
Revar Desmera 2023-07-27 14:42:40 -07:00 committed by GitHub
commit 570fc5ec36
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
gears.scad
View file

@ -2258,6 +2258,17 @@ function _gear_tooth_profile(
for (i=[0:1:steps-1]) 0.2 + i/(steps-1)*0.8, for (i=[0:1:steps-1]) 0.2 + i/(steps-1)*0.8,
], ],
// Is there an undercut?
has_undercut = [
for (u = us) let(
r = lerp(rrad, ma_rad, u),
a1 = lookup(r, involute_lup) + soff,
a2 = lookup(r, undercut_lup),
a = internal || r < undercut_lup[0].x? a1 : min(a1,a2),
b = internal || r < undercut_lup[0].x? false : a1>a2
) if(a<90+180/teeth && b) 1
] != [],
// Generate the left half of the tooth. // Generate the left half of the tooth.
tooth_half_raw = deduplicate([ tooth_half_raw = deduplicate([
for (u = us) let( for (u = us) let(
@ -2287,7 +2298,8 @@ function _gear_tooth_profile(
mti = !angs? 0 : min_index(angs), mti = !angs? 0 : min_index(angs),
out = concat([path[i]], strip_left(path, i + mti + 1)) out = concat([path[i]], strip_left(path, i + mti + 1))
) out, ) out,
tooth_half = strip_left(tooth_half_raw, 0), tooth_half = !has_undercut? tooth_half_raw :
strip_left(tooth_half_raw, 0),
// Mirror the tooth to complete it. // Mirror the tooth to complete it.
tooth = deduplicate([ tooth = deduplicate([