From 71721327b326a91b32abbe8dd9f38aea6e43721d Mon Sep 17 00:00:00 2001 From: Revar Desmera Date: Mon, 1 Sep 2025 00:26:37 -0700 Subject: [PATCH] Corrected some uses of ellipse(circum=true,realign=true) --- hinges.scad | 4 ++-- shapes2d.scad | 2 +- skin.scad | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hinges.scad b/hinges.scad index f5ae1a3..e78ae5c 100644 --- a/hinges.scad +++ b/hinges.scad @@ -458,7 +458,7 @@ module _knuckle_hinge_profile(offset, arm_height, arm_angle=45, knuckle_diam=4, if (is_num(clear_top)) left(.1)fwd(clearance) rect([.1+clear_top, knuckle_diam+1+clearance], anchor=BOT+LEFT); if (is_def(clip)) fwd(clip) left(.1) rect([offset+knuckle_diam, ofs+round_bot+knuckle_diam+abs(clip)],anchor=BACK+LEFT); } - right(offset)ellipse(d=knuckle_diam,realign=true,circum=true); + right(offset)ellipse(d=knuckle_diam, circum=true); } if (is_num(pin_diam) && pin_diam>0){ $fn = default(pin_fn,$fn); @@ -466,7 +466,7 @@ module _knuckle_hinge_profile(offset, arm_height, arm_angle=45, knuckle_diam=4, if (is_def(tearspin)){ teardrop2d(d=pin_diam+2*get_slop(), realign=true, circum=true, spin=tearspin); } - else ellipse(d=pin_diam+2*get_slop(), realign=true, circum=true); + else ellipse(d=pin_diam+2*get_slop(), circum=true); } } } diff --git a/shapes2d.scad b/shapes2d.scad index d4f0efb..85b67e9 100644 --- a/shapes2d.scad +++ b/shapes2d.scad @@ -1448,7 +1448,7 @@ function teardrop2d(r, ang=45, cap_h, d, circum=false, realign=false, anchor=CEN [ cap[0], p, - each select(fullcircle,i+1,-i-1-(realign?1:0)), + each select(fullcircle,i+1,-i-1-(realign!=circum?1:0)), xflip(p), if(_extrapt || !pointycap) xflip(cap[0]) ] diff --git a/skin.scad b/skin.scad index f29ff6b..4933205 100644 --- a/skin.scad +++ b/skin.scad @@ -4359,7 +4359,7 @@ function texture(tex, n, border, gap, roughness, inset) = ) [ [ each hex, - each move([0.5,0.5], p=yscale(sc, p=path3d(ellipse(d=1-2*border, circum=true, spin=-30,$fn=6),1))), + each move([0.5,0.5], p=yscale(sc, p=path3d(ellipse(d=1-2*border, circum=true, realign=true, spin=-30,$fn=6),1))), hex[0]-[0,diag*sc,-1], for (ang=[270+60,270-60]) hex[1]+yscale(sc, p=cylindrical_to_xyz(diag,ang,1)), hex[2]-[0,diag*sc,-1],