grey/BOSL2
1
0
Fork 0
mirror of https://github.com/BelfrySCAD/BOSL2.git synced 2024-12-28 07:49:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #1532 from xloem/gears

Browse source 
propagate fix for negative helix angles
This commit is contained in:
adrianVmariano 2024-12-24 09:49:58 -05:00 committed by GitHub
commit 93752014b6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gears.scad
View file

@ -932,7 +932,7 @@ function spur_gear(
: assert(false,"atype must be one of \"root\", \"tip\" or \"pitch\""), : assert(false,"atype must be one of \"root\", \"tip\" or \"pitch\""),
circum = 2 * PI * pr, circum = 2 * PI * pr,
twist = 360*thickness*tan(helical)/circum, twist = 360*thickness*tan(helical)/circum,
slices = default(slices, ceil(twist/360*segs(pr)+1)), slices = default(slices, ceil(abs(twist)/360*segs(pr)+1)),
rgn = spur_gear2d( rgn = spur_gear2d(
circ_pitch = circ_pitch, circ_pitch = circ_pitch,
teeth = teeth, teeth = teeth,
@ -1437,7 +1437,7 @@ module ring_gear(
: 2*ar - rr; // default case : 2*ar - rr; // default case
circum = 2 * PI * pr; circum = 2 * PI * pr;
twist = 360*thickness*tan(-helical)/circum; twist = 360*thickness*tan(-helical)/circum;
slices = default(slices, ceil(twist/360*segs(pr)+1)); slices = default(slices, ceil(abs(twist)/360*segs(pr)+1));
attachable(anchor,spin,orient, h=thickness, r=atype=="outside"?or:pr) { attachable(anchor,spin,orient, h=thickness, r=atype=="outside"?or:pr) {
zrot(gear_spin) zrot(gear_spin)
if (herringbone) { if (herringbone) {