grey/BOSL2
1
0
Fork 0
mirror of https://github.com/BelfrySCAD/BOSL2.git synced 2025-01-04 03:09:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #1331 from BelfrySCAD/revarbat_dev

Browse source 
Fix for #1329:  wrong $fn in cyl(), rotate_extrude()
This commit is contained in:
Revar Desmera 2023-12-17 23:23:53 -08:00 committed by GitHub
commit 95ade7879c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
skin.scad
View file

@ -986,7 +986,7 @@ function rotate_sweep(
style=style style=style
) : ) :
let( let(
steps = ceil(segs(max_x) * angle / 360) + 1, steps = ceil(segs(max_x) * angle / 360) + (angle<360? 1 : 0),
skmat = down(min_y) * skew(sxz=shift.x/h, syz=shift.y/h) * up(min_y), skmat = down(min_y) * skew(sxz=shift.x/h, syz=shift.y/h) * up(min_y),
transforms = [ transforms = [
if (angle==360) for (i=[0:1:steps-1]) skmat * rot([90,0,360-i*360/steps]), if (angle==360) for (i=[0:1:steps-1]) skmat * rot([90,0,360-i*360/steps]),
@ -1046,7 +1046,7 @@ module rotate_sweep(
spin=spin, orient=orient spin=spin, orient=orient
) children(); ) children();
} else { } else {
steps = ceil(segs(max_x) * angle / 360) + 1; steps = ceil(segs(max_x) * angle / 360) + (angle<360? 1 : 0);
skmat = down(min_y) * skew(sxz=shift.x/h, syz=shift.y/h) * up(min_y); skmat = down(min_y) * skew(sxz=shift.x/h, syz=shift.y/h) * up(min_y);
transforms = [ transforms = [
if (angle==360) for (i=[0:1:steps-1]) skmat * rot([90,0,360-i*360/steps]), if (angle==360) for (i=[0:1:steps-1]) skmat * rot([90,0,360-i*360/steps]),