From 9cf6a0b3a8bd7c9cbfb68a73163ccb515961f5e2 Mon Sep 17 00:00:00 2001 From: Adrian Mariano Date: Fri, 14 Oct 2022 06:19:45 -0400 Subject: [PATCH] bugfix --- screws.scad | 5 ++++- skin.scad | 6 +++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/screws.scad b/screws.scad index 30a06d6..008b7af 100644 --- a/screws.scad +++ b/screws.scad @@ -692,9 +692,12 @@ module screw(spec, head, drive, thread, drive_size, // set counterbore to true and it will be sized to match the head height. The counterbore will extend 0.01 above the TOP of the hole mask to ensure no // problems with differences. Note that the counterbore defaults to true for non-flathead screws. If you want the actual head shape to appear, set counterbore to zero. // . +// For 3d printing circular holes can be problematic. One solution is to use octagonal holes, setting $fn=8. Another option is to use a teardrop hole, which +// can be accomplished by setting `teardrop=true`. The point of the teardrop will point in the Y direction (BACK) so you will need to ensure that you orient it +// correctly in your final model. +// . // Anchoring for screw_hole() is the same as anchoring for {{screw()}}, with all the same anchor types and named anchors. If you specify a counterbore it is treated as // the "head", or in the case of flat heads, it becomes part of the head. If you make a teardrop hole the point is ignored for purposes of anchoring. -// The point of the teardrop is in the Y direction. // Arguments: // spec = screw specification, e.g. "M5x1" or "#8-32". See [screw naming](#subsection-screw-naming). This can also be a screw specification structure of the form produced by {{screw_info()}}. // head = head type. See [screw heads](#subsection-screw-heads) Default: none diff --git a/skin.scad b/skin.scad index 8da85fd..c9fee6c 100644 --- a/skin.scad +++ b/skin.scad @@ -1528,7 +1528,7 @@ module path_sweep(shape, path, method="incremental", normal, closed, twist=0, tw if (profiles){ assert(in_list(atype, _ANCHOR_TYPES), "Anchor type must be \"hull\" or \"intersect\""); - tran = path_sweep(shape, path, method, normal, closed, twist, twist_by_length, + tran = path_sweep(shape, path, method, normal, closed, twist, twist_by_length, scale, symmetry, last_normal, tangent, uniform, relaxed,transforms=true); rshape = is_path(shape) ? [path3d(shape)] : [for(s=shape) path3d(s)]; @@ -1546,8 +1546,8 @@ module path_sweep(shape, path, method="incremental", normal, closed, twist=0, tw function path_sweep(shape, path, method="incremental", normal, closed, twist=0, twist_by_length=true, scale=1, symmetry=1, last_normal, tangent, uniform=true, relaxed=false, caps, style="min_edge", transforms=false, anchor="origin",cp="centroid",spin=0, orient=UP, atype="hull") = - is_1region(path) ? path_sweep(shape=shape,path=path[0], method=method, normal=normal, closed=default(closed,true), scale=scale, - twist=twist, twist_by_length=twist_by_length, symmetry=symmetry, last_normal=last_normal, + is_1region(path) ? path_sweep(shape=shape,path=path[0], method=method, normal=normal, closed=default(closed,true), + twist=twist, scale=scale, twist_by_length=twist_by_length, symmetry=symmetry, last_normal=last_normal, tangent=tangent, uniform=uniform, relaxed=relaxed, caps=caps, style=style, transforms=transforms, anchor=anchor, cp=cp, spin=spin, orient=orient, atype=atype) : let(closed=default(closed,false))