Merge pull request #1530 from xloem/gears

spur_gear: fix negative helix angles
This commit is contained in:
adrianVmariano 2024-12-18 21:17:02 -05:00 committed by GitHub
commit a95916b39e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -1013,7 +1013,7 @@ module spur_gear(
: assert(false,"atype must be one of \"root\", \"tip\" or \"pitch\""); : assert(false,"atype must be one of \"root\", \"tip\" or \"pitch\"");
circum = 2 * PI * pr; circum = 2 * PI * pr;
twist = 360*thickness*tan(helical)/circum; twist = 360*thickness*tan(helical)/circum;
slices = default(slices, ceil(twist/360*segs(pr)+1)); slices = default(slices, ceil(abs(twist)/360*segs(pr)+1));
default_tag("remove", internal) { default_tag("remove", internal) {
attachable(anchor,spin,orient, r=anchor_rad, l=thickness) { attachable(anchor,spin,orient, r=anchor_rad, l=thickness) {
zrot(gear_spin) zrot(gear_spin)