grey/BOSL2
1
0
Fork 0
mirror of https://github.com/BelfrySCAD/BOSL2.git synced 2024-12-29 16:29:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

bugfix

Browse source
This commit is contained in:
Adrian Mariano 2024-07-18 17:12:45 -04:00
parent ff3dbf5343
commit b0d82973f0
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
joiners.scad
View file

@ -664,7 +664,7 @@ module dovetail(gender, width, height, slide, h, w, angle, slope, thickness, tap
// Need taper angle for computing width adjustment, but not used elsewhere // Need taper angle for computing width adjustment, but not used elsewhere
taper_ang = is_def(taper) ? taper taper_ang = is_def(taper) ? taper
: is_def(back_width) ? atan((back_width-width)/2/slide) : is_def(back_width) ? atan((back_width-w)/2/slide)
: 0; : 0;
// This is the adjustment factor for width to grow in the direction normal to the dovetail face // This is the adjustment factor for width to grow in the direction normal to the dovetail face
wfactor = sqrt( 1/slope^2 + 1/cos(taper_ang)^2 ); wfactor = sqrt( 1/slope^2 + 1/cos(taper_ang)^2 );
@ -708,7 +708,7 @@ module dovetail(gender, width, height, slide, h, w, angle, slope, thickness, tap
bigenough = all_nonnegative(column(smallend_half,0)) && all_nonnegative(column(bigend_points,0)); bigenough = all_nonnegative(column(smallend_half,0)) && all_nonnegative(column(bigend_points,0));
assert(bigenough, "Width of dovetail is not large enough for its geometry (angle and taper"); assert(bigenough, "Width (or back_width) of dovetail is not large enough for its geometry (angle and taper");
//adjustment = $overlap * (gender == "male" ? -1 : 1); // Adjustment for default overlap in attach() //adjustment = $overlap * (gender == "male" ? -1 : 1); // Adjustment for default overlap in attach()
adjustment = 0; // Default overlap is assumed to be zero adjustment = 0; // Default overlap is assumed to be zero