From 598183573ad6eb209431ded76937c191ad0bdf6b Mon Sep 17 00:00:00 2001 From: James Pelletier <1105633+pelletjl@users.noreply.github.com> Date: Tue, 13 Jan 2026 20:05:23 -0500 Subject: [PATCH 1/2] fix for knuckle_hinge using both in_place and knuckle_clearance --- hinges.scad | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/hinges.scad b/hinges.scad index 5873576..86df218 100644 --- a/hinges.scad +++ b/hinges.scad @@ -387,6 +387,16 @@ module knuckle_hinge(length, segs, offset, inner=false, arm_height=0, arm_angle= union(){} } } + module in_place_clearance_tag() { + // don't set the tag if it's already set for backward compatibility + if(in_place != false && knuckle_clearance && $tag == "") { + tag("keep") + children(); + } else { + children(); + } + } + in_place_clearance_tag() attachable(anchor,spin,orient, size=[length, arm_height+offset/tan(arm_angle)+knuckle_diam/2+knuckle_diam/2/sin(arm_angle), From 1204e0a0388bf5bd90c121d4d6501d0166fedb32 Mon Sep 17 00:00:00 2001 From: James Pelletier <1105633+pelletjl@users.noreply.github.com> Date: Wed, 14 Jan 2026 13:07:50 -0500 Subject: [PATCH 2/2] use default_tag --- hinges.scad | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/hinges.scad b/hinges.scad index 86df218..e17b261 100644 --- a/hinges.scad +++ b/hinges.scad @@ -387,16 +387,7 @@ module knuckle_hinge(length, segs, offset, inner=false, arm_height=0, arm_angle= union(){} } } - module in_place_clearance_tag() { - // don't set the tag if it's already set for backward compatibility - if(in_place != false && knuckle_clearance && $tag == "") { - tag("keep") - children(); - } else { - children(); - } - } - in_place_clearance_tag() + default_tag("keep", do_tag=in_place != false && knuckle_clearance) attachable(anchor,spin,orient, size=[length, arm_height+offset/tan(arm_angle)+knuckle_diam/2+knuckle_diam/2/sin(arm_angle),