From d097be435bd881bd2d102cdb8d6cafa110b87c14 Mon Sep 17 00:00:00 2001
From: Adrian Mariano <avm4@cornell.edu>
Date: Tue, 5 Jan 2021 23:29:10 -0500
Subject: [PATCH] Add bezier endpoint, tweak _bezcorners to properly produce
 that endpoint.  doc tweak for polyhedra.

---
 beziers.scad   | 18 ++++++++++--------
 polyhedra.scad |  2 ++
 rounding.scad  |  2 +-
 3 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/beziers.scad b/beziers.scad
index 0549a2d..e754183 100644
--- a/beziers.scad
+++ b/beziers.scad
@@ -238,19 +238,20 @@ function bezier_curvature(curve, u) =
     ];
 
 
-
 // Function: bezier_curve()
 // Usage:
-//   bezier_curve(curve, n);
+//   bezier_curve(curve, n, [endpoint]);
 // Description:
-//   Takes a list of bezier curve control points, and a count of path points to generate.  The points
-//   returned will be along the curve, starting at the first control point, then about every `1/n`th
-//   of the way along the curve, ending about `1/n`th of the way *before* the final control point.
-//   The distance between the points will *not* be equidistant.  The degree of the curve, N, is one
+//   Takes a list of bezier curve control points and generates n points along the bezier path.  
+//   Points start at the first control point and are sampled every `1/n`th
+//   of the way along the bezier parameter, ending *before* the final control point by default.
+//   The distance between the points will *not* be equidistant.  If you wish to add the
+//   endpoint you can set `endpoint` to true.  The degree of the bezier curve is one
 //   less than the number of points in `curve`.
 // Arguments:
 //   curve = The list of endpoints and control points for this bezier segment.
 //   n = The number of points to generate along the bezier curve.
+//   endpoint = if true then add the endpoint (an extra point, giving n+1 points output).  Default: False
 // Example(2D): Quadratic (Degree 2) Bezier.
 //   bez = [[0,0], [30,30], [80,0]];
 //   move_copies(bezier_curve(bez, 8)) sphere(r=1.5, $fn=12);
@@ -263,8 +264,9 @@ function bezier_curvature(curve, u) =
 //   bez = [[0,0], [5,15], [40,20], [60,-15], [80,0]];
 //   move_copies(bezier_curve(bez, 8)) sphere(r=1.5, $fn=12);
 //   trace_bezier(bez, N=len(bez)-1);
-function bezier_curve(curve,n) = bezier_points(curve, [0:1/n:(n-0.5)/n]);
-
+function bezier_curve(curve,n,endpoint) = [each bezier_points(curve, [0:1/n:(n-0.5)/n]),
+                                           if (endpoint) curve[len(curve)-1]
+                                          ];
 
 // Function: bezier_segment_closest_point()
 // Usage:
diff --git a/polyhedra.scad b/polyhedra.scad
index 0ea06cb..4bfb2f7 100644
--- a/polyhedra.scad
+++ b/polyhedra.scad
@@ -121,6 +121,7 @@ function _unique_groups(m) = [
 //
 // Arguments:
 //   name = Name of polyhedron to create.
+//   ---
 //   index = Index to select from polyhedron list.  Default: 0.
 //   type = Type of polyhedron: "platonic", "archimedean", "catalan".
 //   faces = Number of faces.
@@ -564,6 +565,7 @@ _stellated_polyhedra_ = [
 //
 // Arguments:
 //   name = Name of polyhedron to create.
+//   ---
 //   index = Index to select from polyhedron list.  Default: 0.
 //   type = Type of polyhedron: "platonic", "archimedean", "catalan".
 //   faces = Number of faces.
diff --git a/rounding.scad b/rounding.scad
index c07664c..62f481c 100644
--- a/rounding.scad
+++ b/rounding.scad
@@ -308,7 +308,7 @@ function _bezcorner(points, parm) =
                         ] : _smooth_bez_fill(points,parm),
                 N = max(3,$fn>0 ?$fn : ceil(bezier_segment_length(P)/$fs))
         )
-        bezier_curve(P,N);
+        bezier_curve(P,N,endpoint=true);
 
 function _chamfcorner(points, parm) =
         let(