From e58cfa0ba139172b62d1eb39d606d5c1a7ba2bdb Mon Sep 17 00:00:00 2001 From: Revar Desmera Date: Tue, 6 Feb 2024 10:26:34 -0800 Subject: [PATCH] Minor docs fixes. Removed VersionBump workflow. --- .github/workflows/pr_merge.yml | 28 ---------------------------- rounding.scad | 6 +++--- 2 files changed, 3 insertions(+), 31 deletions(-) delete mode 100644 .github/workflows/pr_merge.yml diff --git a/.github/workflows/pr_merge.yml b/.github/workflows/pr_merge.yml deleted file mode 100644 index fc8b618..0000000 --- a/.github/workflows/pr_merge.yml +++ /dev/null @@ -1,28 +0,0 @@ -name: VersionBump -on: - push: - branches: - - master - -jobs: - VersionBumpJob: - runs-on: ubuntu-latest - - permissions: - contents: write - - steps: - - name: Checkout - uses: actions/checkout@v4 - with: - ref: ${{ github.head_ref }} - - - name: Bump Version - run: ./scripts/increment_version.sh - - - name: Checkin - uses: stefanzweifel/git-auto-commit-action@v5 - with: - commit_message: Version Bump - file_pattern: version.scad - diff --git a/rounding.scad b/rounding.scad index bb88dc1..b2d973a 100644 --- a/rounding.scad +++ b/rounding.scad @@ -1383,15 +1383,15 @@ module offset_stroke(path, width=1, rounded=true, start, end, check_valid=true, // Example: If the shape has sharp corners, make sure to set `$fn/$fs/$fa`. The corners of this triangle are not round, even though `offset="round"` (the default) because the number of segments is small. // triangle = [[0,0],[10,0],[5,10]]; // offset_sweep(triangle, height=6, bottom = os_circle(r=-2),steps=4); -// Example: Can improve the result by increasing $fn +// Example: Can improve the result by increasing `$fn` // $fn=12; // triangle = [[0,0],[10,0],[5,10]]; // offset_sweep(triangle, height=6, bottom = os_circle(r=-2),steps=4); -// Example: Using $fa and $fs works too; it produces a different looking triangulation of the rounded corner +// Example: Using `$fa` and `$fs` works too; it produces a different looking triangulation of the rounded corner // $fa=1;$fs=0.3; // triangle = [[0,0],[10,0],[5,10]]; // offset_sweep(triangle, height=6, bottom = os_circle(r=-2),steps=4); -// Example: Here is the star chamfered at the top with a teardrop rounding at the bottom. Check out the rounded corners on the chamfer. The large $fn value ensures a smooth curve on the concave corners of the chamfer. It has no effect anywhere else on the model. Observe how the rounded star points vanish at the bottom in the teardrop: the number of vertices does not remain constant from layer to layer. +// Example: Here is the star chamfered at the top with a teardrop rounding at the bottom. Check out the rounded corners on the chamfer. The large `$fn` value ensures a smooth curve on the concave corners of the chamfer. It has no effect anywhere else on the model. Observe how the rounded star points vanish at the bottom in the teardrop: the number of vertices does not remain constant from layer to layer. // star = star(5, r=22, ir=13); // rounded_star = round_corners(star, cut=flatten(repeat([.5,0],5)), $fn=24); // offset_sweep(rounded_star, height=20, bottom=os_teardrop(r=4), top=os_chamfer(width=4),$fn=64);