From 4ba8670a55d273cb692b512dce22e1b6c0a6487d Mon Sep 17 00:00:00 2001 From: Adrian Mariano Date: Mon, 14 Sep 2020 16:48:42 -0400 Subject: [PATCH 1/3] parameter passing bug fix for offset_sweep --- rounding.scad | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/rounding.scad b/rounding.scad index c57a76f..77beae9 100644 --- a/rounding.scad +++ b/rounding.scad @@ -731,6 +731,7 @@ function offset_sweep( ["k", k], ["points", []], ], + afda=echo(extra=struct_val(argspec,"extra")), path = check_and_fix_path(path, [2], closed=true), clockwise = polygon_is_clockwise(path), @@ -804,8 +805,8 @@ module offset_sweep(path, height, h, l, convexity=10,anchor="origin",cp, spin=0, orient=UP, extent=false) { - vnf = offset_sweep(path=path, height=height, h=h, l=l, top=top, bottom=bottom, offset=offset, r=0, steps=steps, - quality=quality, check_valid=true, offset_maxstep=1, extra=0, cut=cut, chamfer_width=chamfer_width, + vnf = offset_sweep(path=path, height=height, h=h, l=l, top=top, bottom=bottom, offset=offset, r=r, steps=steps, + quality=quality, check_valid=true, offset_maxstep=offset_maxstep, extra=extra, cut=cut, chamfer_width=chamfer_width, chamfer_height=chamfer_height, joint=joint, k=k, angle=angle); attachable(anchor=anchor, spin=spin, orient=orient, vnf=vnf, extent=extent, cp=is_def(cp) ? cp : vnf_centroid(vnf)) From fd637ec56dae457b52502eabf074ead7787c44a0 Mon Sep 17 00:00:00 2001 From: Adrian Mariano Date: Mon, 14 Sep 2020 17:31:07 -0400 Subject: [PATCH 2/3] removed echo --- rounding.scad | 1 - 1 file changed, 1 deletion(-) diff --git a/rounding.scad b/rounding.scad index 77beae9..8ff0d5f 100644 --- a/rounding.scad +++ b/rounding.scad @@ -731,7 +731,6 @@ function offset_sweep( ["k", k], ["points", []], ], - afda=echo(extra=struct_val(argspec,"extra")), path = check_and_fix_path(path, [2], closed=true), clockwise = polygon_is_clockwise(path), From ac4178fadcd1b2bcf4c50e92b769414d51fb3037 Mon Sep 17 00:00:00 2001 From: Adrian Mariano Date: Fri, 18 Sep 2020 21:44:05 -0400 Subject: [PATCH 3/3] Remove echo and doc fix for rabbit_clip --- joiners.scad | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/joiners.scad b/joiners.scad index 1d76c36..f68b124 100644 --- a/joiners.scad +++ b/joiners.scad @@ -785,8 +785,7 @@ module snap_pin_socket(size, r, radius, l,length, d,diameter,nub_depth, snap, fi // Module: rabbit_clip() // Usage: -// rabbit_clip(type, length, width, snap, thickness, depth, [compression], [clearance], [lock], -// [lock_clearance], [splineteps], [anchor], [orient], [spin]) +// rabbit_clip(type, length, width, snap, thickness, depth, [compression], [clearance], [lock], [lock_clearance], [splineteps], [anchor], [orient], [spin]) // Description: // Creates a clip with two flexible ears to lock into a mating socket, or create a mask to produce the appropriate // mating socket. The clip can be made to insert and release easily, or to hold much better, or it can be @@ -992,8 +991,8 @@ module rabbit_clip(type, length, width, snap, thickness, depth, compression=0.1 bez = path_to_bezier(path,relsize=smoothing,tangents=tangent); rounded = bezier_polyline(bez,splinesteps=splinesteps); bounds = pointlist_bounds(rounded); - kk = search([bounds[1].y], subindex(rounded,1)); - echo(rounded[kk[0]]); + //kk = search([bounds[1].y], subindex(rounded,1)); + //echo(rounded[kk[0]]); extrapt = is_pin ? [] : [rounded[0] - [0,extra]]; finalpath = is_pin ? rounded : let(withclearance=offset(rounded, r=-clearance))