grey/BOSL2
1
0
Fork 0
mirror of https://github.com/BelfrySCAD/BOSL2.git synced 2025-01-01 09:49:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #1324 from BelfrySCAD/revarbat_dev

Browse source 
Fix for #1320: $fn/$fa/$fs handling in rotate_extrude()
This commit is contained in:
Revar Desmera 2023-12-09 18:57:05 -08:00 committed by GitHub
commit f3e3ec53a7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
skin.scad
View file

@ -986,7 +986,7 @@ function rotate_sweep(
style=style
) :
let(
steps = segs(max_x),
steps = ceil(segs(max_x) * angle / 360) + 1,
skmat = down(min_y) * skew(sxz=shift.x/h, syz=shift.y/h) * up(min_y),
transforms = [
if (angle==360) for (i=[0:1:steps-1]) skmat * rot([90,0,360-i*360/steps]),
@ -1027,7 +1027,6 @@ module rotate_sweep(
max_y = bounds[1].y;
h = max_y - min_y;
check2 = assert(min_x>=0, "Input region must exist entirely in the X+ half-plane.");
steps = segs(max_x);
if (!is_undef(texture)) {
_textured_revolution(
shape,
@ -1047,6 +1046,7 @@ module rotate_sweep(
spin=spin, orient=orient
) children();
} else {
steps = ceil(segs(max_x) * angle / 360) + 1;
skmat = down(min_y) * skew(sxz=shift.x/h, syz=shift.y/h) * up(min_y);
transforms = [
if (angle==360) for (i=[0:1:steps-1]) skmat * rot([90,0,360-i*360/steps]),