mirror of
https://github.com/BelfrySCAD/BOSL2.git
synced 2025-01-06 12:19:47 +00:00
Merge pull request #1324 from BelfrySCAD/revarbat_dev
Fix for #1320: $fn/$fa/$fs handling in rotate_extrude()
This commit is contained in:
commit
f3e3ec53a7
1 changed files with 2 additions and 2 deletions
|
@ -986,7 +986,7 @@ function rotate_sweep(
|
||||||
style=style
|
style=style
|
||||||
) :
|
) :
|
||||||
let(
|
let(
|
||||||
steps = segs(max_x),
|
steps = ceil(segs(max_x) * angle / 360) + 1,
|
||||||
skmat = down(min_y) * skew(sxz=shift.x/h, syz=shift.y/h) * up(min_y),
|
skmat = down(min_y) * skew(sxz=shift.x/h, syz=shift.y/h) * up(min_y),
|
||||||
transforms = [
|
transforms = [
|
||||||
if (angle==360) for (i=[0:1:steps-1]) skmat * rot([90,0,360-i*360/steps]),
|
if (angle==360) for (i=[0:1:steps-1]) skmat * rot([90,0,360-i*360/steps]),
|
||||||
|
@ -1027,7 +1027,6 @@ module rotate_sweep(
|
||||||
max_y = bounds[1].y;
|
max_y = bounds[1].y;
|
||||||
h = max_y - min_y;
|
h = max_y - min_y;
|
||||||
check2 = assert(min_x>=0, "Input region must exist entirely in the X+ half-plane.");
|
check2 = assert(min_x>=0, "Input region must exist entirely in the X+ half-plane.");
|
||||||
steps = segs(max_x);
|
|
||||||
if (!is_undef(texture)) {
|
if (!is_undef(texture)) {
|
||||||
_textured_revolution(
|
_textured_revolution(
|
||||||
shape,
|
shape,
|
||||||
|
@ -1047,6 +1046,7 @@ module rotate_sweep(
|
||||||
spin=spin, orient=orient
|
spin=spin, orient=orient
|
||||||
) children();
|
) children();
|
||||||
} else {
|
} else {
|
||||||
|
steps = ceil(segs(max_x) * angle / 360) + 1;
|
||||||
skmat = down(min_y) * skew(sxz=shift.x/h, syz=shift.y/h) * up(min_y);
|
skmat = down(min_y) * skew(sxz=shift.x/h, syz=shift.y/h) * up(min_y);
|
||||||
transforms = [
|
transforms = [
|
||||||
if (angle==360) for (i=[0:1:steps-1]) skmat * rot([90,0,360-i*360/steps]),
|
if (angle==360) for (i=[0:1:steps-1]) skmat * rot([90,0,360-i*360/steps]),
|
||||||
|
|
Loading…
Reference in a new issue