There were bugs in the previous sorting functions. They didn't check the homogeneity of the input list before calling _sort_scalars and _sort_vectors. The bug might result in wrong order and missing list elements in the output.
Besides correcting the bug a recode of all sorting functions result in better performance and a enlargement of their scope. With the new functions, list of vectors of any dimension may be sorted, even with idx given, with the native comparison operators. The scope of indexed sorting is also extended.
The file test_arrays has been extended to check the new funcionality.
New functions:
is_homogeneous - checks if a list has elements of the same type (although not distinguing booleans from numbers) up to a given depth
_sort_vectors - internal function to sort homgeneous lists of vectors using native comparison operators; extends the scope of the previous _sort_vectors# functions with better performance
_lexical_sort - internal function to sort non-homogeneous lists; uses compare_vals
_indexed_sort - internal function to perform indexed sorting of non-homogeneous lists; uses compar_vals
Changed/reviewed functions:
_valid_idx - doesn't requires the input of imin and imax args
sort - explores the internal functions to get better performance and an enlarged scope
sortidx - explores the internal functions to get better performance and an enlarged scope
_sort_general - just for sortings of non-homogeneous lists using compare_vals
_array_dim_recurse - changed for bit better performance
Functions eliminated:
_sort_vectors1
_sort_vectors2
_sort_vectors3
_sort_vectors4
When the first operand is hidden, some strange things happen, so this guards
against that.
Example:
include <BOSL2/std.scad>
part_to_show = "A"; // [A,B,C]
part_to_hide = "B"; // [A,B,C]
module my_part() {
tags("A") left(10) cuboid(10);
tags("B") diff("neg", "B") right(10) {
cuboid(10);
cyl(d=10, h=10, $tags="neg");
}
tags("C") fwd(10) cuboid(10);
}
show(part_to_show) hide(part_to_hide) my_part();
Tag "B" here acts very strangely when it is supposed to be hidden, and never
hides completely.
Eliminate double definitions.
Eliminate unneeded comments.
In common.scad redefine num_defined(), all_defined() and get_radius().
In geometry.scad:
- change name _dist to _dist2line
- simplify _point_above_below_segment() and triangle_area()
- change some arg names for uniformity (path>>poly)
- change point_in_polygon() to accept the Even-odd rule as alternative
- and other minor edits
Update tests_geometry to the new funcionalities.
