grey/BOSL2
1
0
Fork 0
mirror of https://github.com/BelfrySCAD/BOSL2.git synced 2025-01-15 08:59:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Compare commits

base: grey:0f09d1fac976099f824e4fce705362ebe240b161
Branches Tags
grey:master
grey:revarbat_dev
...
compare: grey:a95916b39e9f6990dab1f0f524e9f1afa64ca9ee
Branches Tags
grey:master
grey:revarbat_dev

2 commits
0f09d1fac9 ... a95916b39e

Author SHA1 Message Date
adrianVmariano
a95916b39e
Merge pull request #1530 from xloem/gears 
spur_gear: fix negative helix angles
 2024-12-18 21:17:02 -05:00
John Doe
db8236dbed spur_gear: fix negative helix angles 
The helix code previously included an assumption that the angle is positive when calculating the slice count, which caused negative angles to always produce only 1 slice.

This fix adds an abs() call around the twist to produce the same slice count for both directions.
 2024-12-18 16:36:38 -07:00
1 changed files with 1 additions and 1 deletions
Show stats Expand all files Collapse all files

2
gears.scad
View file

@ -1013,7 +1013,7 @@ module spur_gear(
: assert(false,"atype must be one of \"root\", \"tip\" or \"pitch\""); : assert(false,"atype must be one of \"root\", \"tip\" or \"pitch\"");
circum = 2 * PI * pr; circum = 2 * PI * pr;
twist = 360*thickness*tan(helical)/circum; twist = 360*thickness*tan(helical)/circum;
slices = default(slices, ceil(twist/360*segs(pr)+1)); slices = default(slices, ceil(abs(twist)/360*segs(pr)+1));
default_tag("remove", internal) { default_tag("remove", internal) {
attachable(anchor,spin,orient, r=anchor_rad, l=thickness) { attachable(anchor,spin,orient, r=anchor_rad, l=thickness) {
zrot(gear_spin) zrot(gear_spin)