x/busybox
1
0
Fork 0
mirror of https://git.busybox.net/busybox synced 2026-02-15 22:16:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

tls: remove unnecessary malloc/free in psRsaDecryptPriv()

Browse source 
function                                             old     new   delta
.rodata                                           108007  108023     +16
psRsaDecryptPriv                                     200     171     -29
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/1 up/down: 16/-29)            Total: -13 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2026-02-12 13:57:23 +01:00
parent 5a1bcdf036
commit 2ab2c25847
1 changed files with 10 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
networking/tls_rsa.c
View file

@ -280,35 +280,23 @@ int32 FAST_FUNC psRsaDecryptPriv(psPool_t *pool, psRsaKey_t *key,
unsigned char *out, uint32 outlen, void *data)
{
int32 err;
uint32 size, ptLen;
unsigned char *tmp;
uint32 ptLen;
size = key->size;
if (inlen != size) {
psTraceCrypto("psRsaDecryptPriv: input size mismatch\n");
if (inlen != key->size) {
psTraceCrypto("Error on bad inlen parameter to psRsaDecryptPriv\n");
return PS_ARG_FAIL;
}
/* Allocate temp buffer for decrypted padded data */
tmp = xmalloc(size);
/* Perform RSA decryption */
ptLen = size;
if ((err = psRsaCrypt(pool, in, inlen, tmp, &ptLen, key,
ptLen = inlen;
if ((err = psRsaCrypt(pool, in, inlen, in, &ptLen, key,
PRIVKEY_TYPE, data)) < PS_SUCCESS) {
psTraceCrypto("Error performing psRsaDecryptPriv\n");
free(tmp);
return err;
}
/* Remove PKCS#1 padding */
err = pkcs1Unpad(tmp, ptLen, out, outlen);
free(tmp);
if (err < 0) {
psTraceCrypto("Error unpadding in psRsaDecryptPriv\n");
if (ptLen != inlen) {
psTraceCrypto("Decrypted size error in psRsaDecryptPriv\n");
return PS_FAILURE;
}
return err; /* Return length of unpadded message */
err = pkcs1Unpad(in, inlen, out, outlen);
memset(in, 0x0, inlen);
return err;
}