x/busybox
1
0
Fork 0
mirror of https://git.busybox.net/busybox synced 2026-01-31 16:43:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

nslookup: code shrink

Browse source 
function                                             old     new   delta
send_queries                                         725     723      -2
nslookup_main                                        822     820      -2
add_query                                             89      86      -3
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-7)               Total: -7 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2023-05-09 19:32:29 +02:00
parent 62775ec4b3
commit dc84002a82
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
networking/nslookup.c
View file

@ -589,6 +589,7 @@ static int RESOLVFUNC res_mkquery(int op, const char *dname, int class, int type
if (l>253 || buflen<n || op>15u || class>255u || type>255u)
return -1;
//TODO: why do we even have the q[] array? Use buf[] directly!
/* Construct query template - ID will be filled later */
memset(q, 0, n);
q[2] = op*8 + 1;
@ -637,7 +638,12 @@ struct query {
unsigned qlen;
// unsigned latency;
// uint8_t rcode;
unsigned char query[512];
/* res_mkquery() balks on names > 253 chars.
* The formed query is 253+18 chars at max.
* Real hostnames are nowhere near that long anyway.
* Use of power-of-2 size means smaller code.
*/
unsigned char query[512 - sizeof(int) - sizeof(char*)];
// unsigned char reply[512];
};