mirror of
https://git.busybox.net/busybox
synced 2026-02-15 14:06:55 +00:00
253c4e787a
Between Busybox 1.24.2 and 1.25.0 the bb_info_msg() function was eliminated and calls to it changed to be bb_error_msg(). The downside of this is that daemons now log all messages to syslog at the LOG_ERR level which makes it hard to filter errors from informational messages. This change optionally re-introduces bb_info_msg(), controlled by a new option FEATURE_SYSLOG_INFO, restores all the calls to bb_info_msg() that were removed (only in applets that set logmode to LOGMODE_SYSLOG or LOGMODE_BOTH), and also changes informational messages in ifplugd and ntpd. The code size change of this is as follows (using 'defconfig' on x86_64 with gcc 7.3.0-27ubuntu1~18.04) function old new delta bb_info_msg - 182 +182 bb_vinfo_msg - 27 +27 static.log7 194 198 +4 log8 190 191 +1 log5 190 191 +1 crondlog 45 - -45 ------------------------------------------------------------------------------ (add/remove: 2/1 grow/shrink: 3/0 up/down: 215/-45) Total: 170 bytes If you don't care about everything being logged at LOG_ERR level then when FEATURE_SYSLOG_INFO is disabled Busybox actually gets smaller: function old new delta static.log7 194 200 +6 log8 190 193 +3 log5 190 193 +3 syslog_level 1 - -1 bb_verror_msg 583 581 -2 crondlog 45 - -45 ------------------------------------------------------------------------------ (add/remove: 0/2 grow/shrink: 3/1 up/down: 12/-48) Total: -36 bytes Signed-off-by: James Byrne <james.byrne@origamienergy.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> |
||
|---|---|---|
| .. | ||
| adjtimex.c | ||
| bbconfig.c | ||
| bc.c | ||
| beep.c | ||
| chat.c | ||
| Config.src | ||
| conspy.c | ||
| crond.c | ||
| crontab.c | ||
| dc.c | ||
| devfsd.c | ||
| devmem.c | ||
| fbsplash.c | ||
| fbsplash.cfg | ||
| flash_eraseall.c | ||
| flash_lock_unlock.c | ||
| flashcp.c | ||
| hdparm.c | ||
| hexedit.c | ||
| i2c_tools.c | ||
| inotifyd.c | ||
| Kbuild.src | ||
| less.c | ||
| lsscsi.c | ||
| makedevs.c | ||
| man.c | ||
| microcom.c | ||
| mt.c | ||
| nandwrite.c | ||
| partprobe.c | ||
| raidautorun.c | ||
| readahead.c | ||
| rfkill.c | ||
| runlevel.c | ||
| rx.c | ||
| setfattr.c | ||
| setserial.c | ||
| strings.c | ||
| time.c | ||
| ts.c | ||
| ttysize.c | ||
| ubi_tools.c | ||
| ubirename.c | ||
| volname.c | ||
| watchdog.c | ||