Tim Starling
7688101426
Removed JS2 work (has been moved to the js2-work branch). Has been lightly tested, should mostly work. Some of the more complicated associated changes are listed below.
...
* Reverted HttpFunctions.php to r45549 and renamed wgSyncHTTPTimeout back to wgHTTPTimeout
* Edited out the asynchronous features from UploadFromUrl. Made fetchFile() use the curlCopy() function from new-upload r47811 instead of Http::doDownload(). Wrote my own URL validity check to avoid having to use either of the two buggy precedents.
* Removed UploadFromChunk
* Removed chunk upload and background status from ApiUpload.php
* Reverted r54669, use of addScriptClass()
* Left getHeadScripts() in its current location (OutputPage) instead of moving it back to SkinTemplate, just added wikibits.js to it to replace the removed addCoreScripts2Top()
2009-11-26 12:00:36 +00:00
Sam Reed
9546d0bffc
Apply patch from bug 21589 API: Separate summary and initial page text for uploads
2009-11-22 15:14:19 +00:00
Tim Starling
251c21e84b
Rework of libAddMedia. The changes are entirely untested and there may be bugs, but at least the code is nicer to look at now. This commit message is probably incomplete.
...
In libAddMedia:
* Made many style changes, renamed many variables.
* Wrote a doc comment for most functions
* Renamed messages:
* fogg-check_for_fogg -> fogg-check_for_firefogg
* fogg-for_improved_uplods -> fogg-for_improved_uploads
* fogg-use_latest_fox -> fogg-use_latest_firefox
* mwe-upload-stats-fileprogres -> mwe-upload-stats-fileprogress
* Renamed functions:
* doRemapFormToApi -> remapFormToApi
* doUploadSwitch -> doUpload
* proccessIframeResult -> processIframeResult
* getEditForm -> getForm
* dispProgressOverlay -> displayProgressOverlay
* cancel_button -> getCancelButton
* cancel_action -> onCancel
* doControlHTML -> createControls
* getTargetHtml -> getControlHtml
* doControlBindings -> bindControls
* getOSlink -> getFirefoggInstallUrl
* doPreviewControl -> createPreviewControls
* doRenderPreview -> renderPreview
* selectFogg -> selectSourceFile
* selectFoggActions -> updateSourceFileUI
* saveLocalFogg -> doLocalEncodeAndSave
* doChunkWithFormData -> doChunkUploadWithFormData
* proccessPresetControl -> getPresetControlHtml
* proccessCkControlHTML -> getConfigControlHtml
* selectByUrl -> selectSourceUrl
* Promoted anonymous functions to methods:
* onSubmit
* onAjaxUploadStatusTimer
* onAjaxUploadStatusResponse
* onPreviewClick
In mvBaseUploadInterface:
* Made http_copy_upload lazy-initialised
* Made detectUploadMode() do only what it says, moved the actual upload stage to a callback.
* Refactored doUpload(), splitting out doApiCopyUpload() and doPostUpload()
* Refactored apiUpdateErrorCheck() into isApiSuccess() and showApiError()
In mvFirefogg:
* Made have_firefogg, sourceFileInfo lazy initialised
* Rearranged autoEncoderSettings() to make it the accessor getEncoderSettings()
* Rearranged firefoggCheck() to make it the accessor getFirefogg()
* Split encodeDone into the anonymous doEncode() done callbacks, and also the new function onLocalEncodeDone()
In mvAdvFirefogg:
* Refactored autoEncoderSettings() into getEncoderSetings() and updateSourceFileUI()
Elsewhere:
* Fixed spelling error UploadBase::MIN_LENGHT_PARTNAME
2009-11-20 07:23:08 +00:00
Max Semenik
cfd54c3810
tab to spaces
2009-11-19 18:04:55 +00:00
Sam Reed
9e7d9df761
bug 19523 prop=info&inprop=watched
2009-11-19 17:57:27 +00:00
Siebrand Mazeland
e8a65f9e25
Update break notation to self enclosed and properly spaced
2009-11-14 20:59:15 +00:00
Bryan Tong Minh
6fec9d682b
Follow-up to r58633 and r58628 (lqt): Rename Title::getProtectionTypes to Title::getRestrictionTypes and fix the hook name.
2009-11-09 12:05:30 +00:00
Roan Kattouw
f9d79167d3
API: (bug 20967) action=edit allows creation of invalid titles that look like interwiki titles. Patch by Sam Reed
2009-11-06 14:44:04 +00:00
Roan Kattouw
1b89cd274a
API: (bug 20554) Expose average slave lag (avglag) as well as maxlag. Patch by Sam Reed.
2009-11-06 14:38:55 +00:00
Andrew Garrett
f6f5e90888
Enabling changes for r56828: some refactoring and code cleanup of the protection interface, including a new hook, generalisation to more restriction types than edit/move, and some other related changes.
2009-11-06 10:27:44 +00:00
Alexandre Emsenhuber
3978f827a6
* (bug 21083) API: list=allusers no longer returns current timestamp for users without registration date
2009-11-04 17:18:05 +00:00
Raimond Spekking
534bce0273
Follow-up r55613: Fix typo. I guess that 'baddaccess-groups' was a typo because such a message does not exists.
...
But 'badaccess-groups' has two parameters: $1 a list of groups and $2 the count of them. These parameters are missing.
2009-11-04 16:07:42 +00:00
Roan Kattouw
038301df2c
Another fatal in r58419
2009-11-03 14:00:20 +00:00
Siebrand Mazeland
e5e9095bd6
Fix parse error from r58419
2009-11-03 06:56:29 +00:00
Roan Kattouw
fc92a38146
Redo r58410, r58411 (attempts to to fix r58399) properly: isset vs. !is_null wasn't the problem, it's that the 'tag' parameter wasn't in the parameter list.
2009-11-02 08:29:26 +00:00
Alexandre Emsenhuber
cf29f11285
Fix for r58410: isset already checks for null, no need to do a double check :)
2009-11-01 21:54:25 +00:00
Siebrand Mazeland
e9f61edfa4
Should fix Undefined index: tag in includes/api/ApiQueryRevisions.php on line 152 from r58399.
2009-11-01 21:49:24 +00:00
Roan Kattouw
1d471caa46
API: (bug 19004) Add support for tags. Patch by Matthew Britton
2009-11-01 10:42:41 +00:00
Bryan Tong Minh
3d6ca209f3
* Validate sessionkey for stashed uploads
...
* (bug 21235) Switch around fetchfileerror to the proper order
2009-10-28 22:23:00 +00:00
Bryan Tong Minh
be1cd24b80
Throw a bit more helpful unknownerror at AS_END, indicating that AS_END was encountered. This actually needs fixing higher up, but this at least clarifies for now what kind of unknownerror occurred.
2009-10-28 13:35:39 +00:00
Raimond Spekking
a0d01f9cae
Follow-up r58237: fixing PHP Notice: Undefined variable: deprecated in /var/www/w/includes/api/ApiBase.php on line 633
2009-10-28 05:20:17 +00:00
Michael Dale
7e0fcad32b
( bug 21320 ) adds early checks for wgAllowCopyUpload and 'upload_by_url' permission so that web server does not make extra requests.
2009-10-28 03:38:23 +00:00
Chad Horohoe
c660ee428f
(bug 21106) tag deprecated parameter in action=paraminfo. Add new PARAM_DEPRECATED const for automagically tagging deprecated parameters. Keeps action=help and action=paraminfo up to date
2009-10-28 00:56:07 +00:00
Alexandre Emsenhuber
5c5e7d674d
* (bug 21085) list=deletedrevs no longer returns only one revision when drcontinue param is passed
2009-10-24 11:50:10 +00:00
Alex Z
216e60d01e
(bug 18019) Warn users when moving a file to a name in use on a shared repo.
...
Allow only users with the 'reupload-shared' right to complete the move.
2009-10-24 04:36:11 +00:00
Niklas Laxström
d4b444a0d6
Fix syntax errors from r57989
2009-10-22 06:18:41 +00:00
Alexandre Emsenhuber
e8f9ef9409
Fix for r57986: Notice: Undefined variable: wgEnableOpenSearchSuggest in includes/api/ApiOpenSearch.php on line 53
2009-10-21 21:22:00 +00:00
Max Semenik
ae57ab1eec
(bug 20275) Fixed LIKE queries on SQLite backend
...
* All manually built LIKE queries in the core are replaced with a wrapper function Database::buildLike()
* This function automatically performs all escaping, so Database::escapeLike() is now almost never used
2009-10-21 19:53:03 +00:00
Roan Kattouw
99748cf05c
Split allowing &suggest requests in API opensearch from $wgEnableMWSuggest to a separate variable. This makes it possible to enable SimpleSearch (which uses API opensearch) but disable mwsuggest; enabling both seems to cause issues with the login form in Safari or Opera (don't remember which)
2009-10-21 18:44:58 +00:00
Bryan Tong Minh
91e4d80448
Rewrote Special:Upload to allow easier extension. Mostly backwards compatible towards the end user: tested with Commons' upload scripts.
...
* Special:Upload now uses HTMLForm for form generation
* Upload errors that can be solved by changing the filename now do not require reuploading.
2009-10-18 19:41:01 +00:00
Aaron Schulz
ec1f410561
Removed unexplained newline at top of file. No idea why that got there.
2009-10-17 05:10:21 +00:00
Aaron Schulz
9be4e7686c
Follow up r57846: tack on an error code
2009-10-17 05:06:41 +00:00
Aaron Schulz
60660e2af3
* Fixed fatal for bad wlowner usernames
...
* Use the relevant user object to check patrol abilities rather than always using $wgUser
2009-10-17 04:18:49 +00:00
Alexandre Emsenhuber
ca82f5720a
* (bug 21105) API: list=usercontribs can now list contribs for User:0
2009-10-15 21:21:53 +00:00
Michael Dale
ab2745e92b
* ( bug 21089 ) fixes js2 upload stash support.
...
* Tested with chunk firefogg uploads, normal js2 uploads and http copy by url uploads
2009-10-15 00:14:05 +00:00
Chad Horohoe
c319cc8968
(bug 13750) $wgCapitalLinks should be a per-namespace setting
2009-10-09 12:52:16 +00:00
Alexandre Emsenhuber
168a1a8f90
replaced split() with explode(), the former is deprecated since PHP 5.3
2009-09-28 18:36:15 +00:00
Siebrand Mazeland
f854edfe87
New permission 'sendemail' added. Default right for all registered users. Can for example be used to prevent new accounts from sending spam.
...
* hide some user settings if user is not allowed to send e-mail, but can receive e-mail
* update API 'cannot send e-mail' message
* FIXME: gives 'mailnologin'/'mailnologintext' as error. Error handling should be made more fine grained
2009-09-26 23:11:45 +00:00
Roan Kattouw
0a7ce36121
API: (bug 20816) Editing a page with &watchlist=preferences (default) unwatches it if you're watching it but don't have watching preferences set. This is a regression from r53266
2009-09-26 09:22:44 +00:00
Brion Vibber
0d1d984313
Revert broken rewrite of login system; totally broken.
...
* Login doesn't attach to session properly, so can't stay logged in!
* Password field shown in plaintext!
If it just DOESN'T WORK please keep it on a work branch, don't put it in trunk!
Reverted:
r56682
r56683
r56684
r56686
r56688
r56696
r56699
r56702
r56703
r56704
r56782
r56896
2009-09-26 00:49:32 +00:00
Roan Kattouw
6d638b24cb
API: Handle image redirects properly in imageinfo, based on reports of API requests dying with backtraces on Commons, e.g. http://commons.wikimedia.org/w/api.php?action=query&prop=imageinfo&iiprop=user&titles=File:Semaphore_Alfa.svg
2009-09-23 20:55:54 +00:00
Happy-melon
ecb1cad872
Follow-ups to r56684: add a member function for extensions to add header text cleanly, and tweak variable names in api/ApiLogin.php.
2009-09-20 21:24:48 +00:00
Happy-melon
d3f901b029
Merge in Login rewrite, second time lucky.
2009-09-20 20:28:27 +00:00
Bryan Tong Minh
bc20609885
Follow up to r56639: Remove some existence check duplication and fix ApiUpload for changed return format of getExistsWarning.
2009-09-19 15:49:54 +00:00
Roan Kattouw
9661f21b82
* API: (bug 20700) Add amprop=default to list default messages in list=allmessages. This adds default="defaultmessagecontent" or defaultmissing="" to customized messages; non-customized messages get no extra attribute.
...
* Don't parse magic words in messages returned by meta=allmessages , but output the message contents verbatim
2009-09-18 15:24:00 +00:00
Roan Kattouw
fba3528881
Partial revert of r56602: remove what is probably accidentally committed debugging code.
2009-09-18 14:38:59 +00:00
Andrew Garrett
4c36759b69
Force changedfilter parameter to integer on Special:AbuseFilter.
...
Resolves bug 20496
2009-09-18 14:30:05 +00:00
Roan Kattouw
ef4886778f
API: Per CR comments on r56091, make the timeout for the API help cache configurable
2009-09-17 19:39:34 +00:00
Alex Z
68596ac79c
merge most of r56515 back to trunk (changing UserrightsPage::fetchUser to non-static)
...
Fixing ApiQueryUsers so it should work properly for interwiki users
2009-09-17 16:21:27 +00:00
Roan Kattouw
87d401f2e6
Fix r56091: cache URLs with and without ?version separately
2009-09-17 15:47:44 +00:00