The extensive label for the "how" of the form in English obscures the "what". By
splitting the radio button's label into a short "what" and retaining the current
message, which in English is currently *entirely* a "how", allows translators to
retain the opportunity to advise their users about the manner in which this will
affect their experience.
Change-Id: I5ca2fb56ee4b50bd6af9b13dfe3c50c1f661a4e8
Follow-up to I3f95489074d220188cbb20cfc4f129712f8b3544.
Input and buttons should now both be exactly 32px tall.
Change-Id: Id9eb662c314f20554baebe3b314ad89559f8b887
When page loads, cancel button doesn't get
focus when user hits the tab button continuously.
Hence tabbing is not intuitive to keyboard only users.
Adding a tabindex property to the cancel button to force the button to
belong in the same tab order as "Save Changes", "Show Preview" and
"Show Changes" button .
Bug: T246257
Change-Id: I38e6c6e047ce93d7101e91d1b94c198f0ff7a19a
It uses $wgUser, but rather than adding a user parameter, the whole
method can just be deprecated and removed. All existing calls have
already been updated.
Bug: T245195
Change-Id: Id7d67cd69d87283cb88455593a4a183c4a5c7721
The API validator logic falls back to PARAM_MAX2 when PARAM_MAX is
not defined, but the Special:ApiSandbox JS validation didn't;
instead it used an effective max of 0.
Change-Id: I22338f7293587878e3ba0f4951b75472968c3d7c
There's no other way to detect parameters, since variable names are
often mentioned in the description prose, even at the start of a line.
Change-Id: Ie375ecffaae4efa268c5305ea9b1cc55a91cd813
This was created for mediawiki.Uri, which no longer uses it
as of I1baa1465d88. It was never used anywhere else in any
repo in Wikimedia Gerrit, nor anywhere else indexed by
Codesearch.
Bug: T233676
Change-Id: Idcc31732fcfec95be63793e870966ab8cb2c2212
Add a clarifying comment to the current origin of the
mw-prefsection-rendering-skin-prefs ID.
Bug: T242381
Change-Id: I7ee636de1f678e871ca1b422f4faf353d864dc17
Currently the updateCollation maintenance script throws an error
when ran, as it calls MediaWikiServices before it's initialized.
See the phab task for more details.
Bug: T246127
Change-Id: Ib9d6b485b55760897ff5152b5d6f22b0d6a36daa
As noted in the task, UID is a read-only variable by default in Bash. Rather
than rely on it existing let's explicitly define MW_DOCKER_(UID/GID) for use
with docker-compose.override.yml.
Bug: T246020
Change-Id: I768486858bc63393f35c3b89fb783c3845183da5
ProfilerExcimer is a MW core class. This code was meant to detect the
extension (which defines ExcimerProfiler not ProfilerExcimer) and if it
is not present, to use the stubs.
This is finding 01 of the wps.de review.
Change-Id: I76b417859b99bafd92a8b8a4b361f8e3cef0100a
It breaks my script.
Remove the IContentHandlerFactory consts without deprecation, they were
only introduced two weeks ago and are not used by anything.
Change-Id: I22eb637b64a9be8472affed1b4ae60c8fa3af93d
Deciding on the shape of the contents of this string seems out of
scope for this class. It just needs to return what is in the string
and make sure to match anything that isn't the string value of
the MW_VERSION constant. That means we need to capture from quote
to quote.
Change-Id: Iee734f8cb425be49601ee4211bb9c01f04164a3f
$wgVersion is not a configuration variable, it should never be
changed at run-time.
While we've gone in the route of class constants for most constants,
this one will not benefit from class-autoloading since it needs to
be present from the very beginning.
MW_VERSION is named similarly as PHP_VERSION, and $wgVersion is
now soft-deprecated.
Bug: T212738
Change-Id: I04628de4152dd5c72646813e08ff35e422e265a4
