We already do this for the pure-PHP backend, and it's easy to
catch this single error and pass a more specific message
Change-Id: I8a81dd90b691c35c51a19f8790f06578dd067613
Per the docs, curl_error() returns a full error string, not an int
or string of an int. Just remove that and pass the error back up.
Change-Id: I7434bb2abda056fdee4d670c192b304c0cdf24f7
* Removed spaces around array index
* Removed double spaces or added spaces to begin or end of function
calls, method signature, conditions or foreachs
* Added braces to one-line ifs
* Changed multi line conditions to one line conditions
* Realigned some arrays
Change-Id: Ia04d2a99d663b07101013c2d53b3b2e872fd9cc3
0543c7b0 added a wfProfileIn() that should have been wfProfileOut()
Reorder Http::request() so that wfProfileOut() is at the same
level as the above wfProfileIn() [checked by check-vars]
Change-Id: Ia91445d792e524b9c570890397f1513af0d8cd73
Added profile calls to various functions in
MWHttpRequest as well as to the wrapper
function Http::request.
Change-Id: I7f2819a075891dbc565a7524d56e7bf077ab089a
* Ran spell-checker over code comments in /includes/
* A few spellchecking fixes for wfDebug() calls
Found one very strange (NOOP?) line in Linker.php - see "TODO: BUG?"
Change-Id: Ibb86b51073b980eda9ecce2cf0b8dd33f058adbf
Doxygen expects parameter types to come before the
parameter name in @param tags. Used a quick regex
to switch everything around where possible. This
only fixes cases where a primitve variable (or a
primitive followed by other types) is the variable
type. Other cases will need to be fixed manually.
Change-Id: Ic59fd20856eb0489d70f3469a56ebce0efb3db13
Added/removed spaces around logical/arithmetic operator
Reduced multiple empty lines to one empty line
Removed wrong tabs before comments at end of line
Removed too many spaces in assigments
Change-Id: I2bba4e72f9b5f88c53324d7b70e6042f1aad8f6b
(bug 42441) The previous patch unnecessarily broke backwards
compatibility in the Http::request() API, following cURL's broken
conventions for sslVerifyHost instead of the boolean interpretation
expected by all existing callers. This change reverts that one, and
fixes the bug in another way. See Ia6535f10.
Also don't bother wrapping the $this->sslVerifyHost access with isset()
since it's always set.
Change-Id: Ia4e1689249b6ac515b859ea2eca1dcff3e63098c
Changed the default value for CURLOPT_SSL_VERIFYHOST
to 2 rather than true. This makes sure that hostname
validation occurs.
Change-Id: Ia6535f1090627ef2def360bda37c22bff10c7f31
This class is not for direct initialization, and
new MWHttpRequest(...)->execute() doesn't work at all.
Change-Id: I557723c218cd8e8f27283d01141c890263da095d
@fixme is simply not recognized by doxygen whereas @todo is used to
generate a nice ... todo list!!
Change-Id: If956c0a164373126ce48b791d45c56962034eecd
* respHeaders contains arrays for each header (should've been
respHeaders['content-length'][0] instead of respHeaders['content-length'])
using getResponseHeader() instead.
* This also fixes InstantCommons, which was broken by this (bug 36653).
* Also cleaned up a bit of w/s in foreign repo code while in the area.
Change-Id: I429b0a36618cc2b873077516e9c1023dc5b7d693
We detect such prematurely ended request when there's a Content-Length
greater than the body we got. A strict comparison would easily fail
when there was a content encoding layer, but hopefully we won't hit
a compressed request _larger_ than the original content.
See http://thread.gmane.org/gmane.org.wikimedia.mediawiki/39622
for breakage caused by truncated HTTP replies.
Change-Id: I71418424730d46a781bde5cbfda8038457ec79c5
examining MWHttpRequest::method always expects its value to be
fully uppercased.
Yes, this should not be a problem if MWHttpRequest is accessed
via HTTP class, but that will not always be guaranteed.
Resolves bug 36137.
Change-Id: Ic20e1b99dcb56b8a11cea50293ba44022e564de9
