This was a temporary flag to allow setting the migration stage for a
comment migration with a temp table.
Since the rev_comment_id migration is done, this is no longer needed.
Dropping the compatibility code for temp tables will be done in
follow-ups.
Bug: T299954
Change-Id: I290a74f27b05cd7e062dda78766911ffe3053d08
Going forward we do not want to use the targets system in the way
we traditionally used it. While updating existing usages will take
time it seems like it might be a good idea to prevent additional usages
being added. This list would gradually be updated as we update those
components.
Bug: T127268
Depends-On: Ibd7270abc5f223bc4f4814c896e7ef4d02d21386
Change-Id: I2e226c174be88caeb505738645cfa0582e39a197
At WMF, we get about 36,000 pre-send warnings from TransactionProfiler
(Logstash: mediawiki-rdbms-performance), of which 9000 are from
ApiLogout.
For example:
> Expectation (writes <= 0) by ApiMain::setRequestExpectations not met
> (actual: 1):
> role-primary: INSERT INTO `cu_changes` (…) VALUES (N,...,N,'X',N,...,N)
These are actually fine as-is given that api?action=logout already
requires POST method and CSRF tokens. We just didn't indicate yet
that it was expected to perform writes (as opposed to using POST for
cache reasons or due to query size).
Change-Id: I89aa7bf672fbf71f153971ad9c0a5d6fbb7733f5
This follows up change I608566700c, which was mainly generated by a
script. Most of the clean up here is fixing cases where it seems the
script for some reason collapsed multi-line arrays into single-line ones
and/or removed spaces after commas. A handful of other improvements are
included too (split merged conditions into ->where()->andWhere(), use
buildComparison()). In RevDelArchiveItem, a comment is restored that I
assume was removed accidentally (perhaps because the script didn’t
expect comments inside the conditions).
Bug: T330640
Change-Id: If27bafb12fdaa05d3dc1ae6da820e1630ae2742e
Follows-Up: I608566700c6d737ee986bf47dda87effc69614d6
I did this using a script written on top of antlr4 parser so it doesn't
have some clean ups a human would do but it's pretty nice already.
Bug: T330640
Change-Id: I608566700c6d737ee986bf47dda87effc69614d6
In e346a4e8ca Codex was updated from
v0.11.0 to v0.12.0, but the version numbers in foreign-resources.yaml
were not changed.
Change-Id: I7872f25a8a68dbdbb1c8bffed78aba7f92e3b648
Rename from testRun(), which looked like a test case missing a
data provider, to makePingback(). Also restructure it such that
the callers call run() instead of the utility method doing this.
Change-Id: I5fdde8ea8dc777469300deb15c4089ad57c264b9
